Opened 11 years ago
Closed 10 years ago
#10853 closed Bug (fixed)
Image2: De-captioning unaligned image produces a widget without a paragraph wrapper
| Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3.1 |
| Component: | General | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description
- Open samples/plugins/image2/image2.html
- Start with the following code:
<figure class="caption"> <img alt="Saturn V" src="assets/image1.jpg" width="200" /> <figcaption>Roll out of Saturn V on launch pad</figcaption> </figure> - Double click the widget. Make sure that alignment is "none" and caption is turned off.
- Inspect editable's code.
- Actual:
<body> <span class="cke_widget_wrapper"> ... </span> </body> - Expected structure:
<body> <p> <span class="cke_widget_wrapper"> ... </span> </p> </body>
- Actual:
- Switching to source and back to WYSIWYG wraps the widget in P.
Change History (8)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 11 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
| Milestone: | CKEditor 4.3 → CKEditor 4.3.1 |
|---|
comment:4 Changed 10 years ago by
| Status: | assigned → review |
|---|
comment:5 follow-up: 6 Changed 10 years ago by
| Status: | review → review_failed |
|---|
You should check editor.activeEnterMode rather than editor.config.enterMode.
comment:6 Changed 10 years ago by
| Status: | review_failed → review |
|---|
Replying to Reinmar:
You should check editor.activeEnterMode rather than editor.config.enterMode.
Nice catch. Fixed.
comment:7 Changed 10 years ago by
| Status: | review → review_passed |
|---|
Rebased branches and pushed one additional commit to dev.
comment:8 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
git:73ec76c landed in master.
Note: See
TracTickets for help on using
tickets.
The solution pushed to t/10853 (+extensive test coverage).