CKEDITOR.template does not accept new line characters

[Piotrek Koszuliński]

This will throw an error:

new CKEDITOR.template( '{foo},\n {bar}' ).output( { foo: 1, bar: 2 } );

Related: #11216.

[Jakub Ś]

You can use below as workaround:

tpl = new CKEDITOR.template( '{foo}, \\n {bar}' );
console.log( tpl.output( { foo: '1', bar: '2'} ) );

[Piotrek Koszuliński]

Duplicate closed: #11236.

[Marek Lewandowski]

Issues fixed in ​t/11216 at dev and tests. In this commit i've also moved regular expressions into separate variables, so these will be compiled only once, instead doing that in each commit.

I have mixed feelings about:

.replace( reEscapableChars, "\\$1" )
.replace( reNewLine, "\\n" )
.replace( reCarriageReturn, "\\r" )

Does any1 of you guys have any better idea how to combine these cases into single call or sth?

Also i checked performance and function does work more or less slightly faster or the same as original (except for ie8 and ff25), ​link to test.

Remark: at the end i couldn't apply optimisation with dot access, rather than square bracket, since some variables have names like 'z-index' etc.

Related issue:
#11102

[Piotrek Koszuliński]

And the comment still says:

Escape all quotation marks (").

Please update it.

Regarding performance - that test is far from being realistic. After first pass, template is returned from cache and the template is empty, so there's no data usage. Building interesting test case for that would take some time and the template class is not something we need to optimize, so that wouldn't help us.

[Marek Lewandowski]

Updated ​t/11216

[Piotrek Koszuliński]

Just one question - why is this ticket on review, when branch is called t/11216? Does this branch fixed this ticket and #11216? Then it still should be handled #11216.

[Marek Lewandowski]

Yeah i pushed initially this solution into t/11216 since the same change fixes both tickets, we can update #11216 to review, and continue there, otherwise, after R+ we can drop msg there that it has been handled in this ticket.

[Piotrek Koszuliński]

I pushed ​t/11102 branches and deleted t/11216.

[Piotrek Koszuliński]

I updated t/11102 on dev and tests with some minor improvements.

[Marek Lewandowski]

Fixed with ​git:ac305ede7397f8 to master at dev.