Ticket #1149 (new New Feature)

Opened 15 months ago

Last modified 11 months ago

Add default action on face for FCKToolbarPanelButton + plugin for alternate OL/UL/color/size buttons

Reported by: mjk Owned by:
Priority: Normal Milestone:
Component: UI : Toolbar Version:
Keywords: HasPatch Cc:

Description

It's common for toolbar buttons in other applications to do a default action if you click on the button face, and only drop a panel (as FCKToolbarPanelButton does) when you click the arrow -- if there is one. At present, FCKToolbarPanelButton doesn't maintain the distinction between dropping down the panel and making a default action.

Enclosed is a patch to enable ToolbarPanelButton to pass to the toolbar command object whether or not the user clicked the dropdown arrow or the face, so that the command object can behave accordingly. This also adds the ability for ToolbarPanelButton to be context-sensitive -- necessary if you're implementing things like UL and OL.

Also enclosed is a plugin that uses the patched functionality. The plugin overloads FCKTextColorCommand so that the last color you used is the default action on the button face. It also adds DropOL, DropUL, and DropFontSize to use the same functionality to provide dropdowns for setting your OL/UL styles and font sizes.

In local testing, the patches to ToolbarPanelButton are sufficiently encapsulated so as not to break existing ToolbarPanelButtons.

Attachments

dropbar.zip (3.7 KB) - added by mjk 15 months ago.
Trunk patch and plugin

Change History

Changed 15 months ago by mjk

Trunk patch and plugin

Changed 11 months ago by mjk

  • keywords Review? added

Changed 11 months ago by fredck

  • keywords HasPatch added; Review? removed

It is nice to hear you again mjk.

We have introduced a new workflow for tickets handling, patches proposal and review. I'm correcting the Keywords in this ticket to reflect our new standards.

Note: See TracTickets for help on using tickets.