Ticket #1227 (closed Bug: fixed)

Opened 13 months ago

Last modified 13 months ago

Stop caching panel type in FCK._ActiveColorPanelType

Reported by: matthiasmiller Owned by:
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: General Version:
Keywords: Cc:

Description

Currently, when the color panel opens its popup, it caches the current color type (ForeColor vs. BackColor) in FCK._ActiveColorPanelType. Although I don't know the history of this variable, it appears that the panel type can safely be retrieved from this.Type.

This would allow other code (besides the popup) to change the selected text to a specific color.

Attachments

fcktextcolorcommand.js.patch (1.2 kB) - added by matthiasmiller 13 months ago.

Change History

Changed 13 months ago by matthiasmiller

Changed 13 months ago by alfonsoml

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to FCKeditor 2.5

You're right, I don't see any reason to keep it.

Fixed with [828], thanks.

Note: See TracTickets for help on using tickets.