Opened 9 years ago
Last modified 9 years ago
#13712 confirmed Task
Migrate the entire code base to strict mode
| Reported by: | Piotrek Koszuliński | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
Currently only ~25% of files are in strict mode. Unfortunately, historically some ugly concepts like arguments.callee were used what makes the transition tricky.
I pushed branch:strict-mode with some basic changes. Unfortunately, it seems that I didn't resolve the arguments.callee usages correctly as few tests started failing. Namely (on Chrome at lest):
- http://tests.ckeditor.dev:1030/tests/plugins/dialogui/dirmarker
- http://tests.ckeditor.dev:1030/tests/plugins/image/image
- http://tests.ckeditor.dev:1030/tests/plugins/image2/editing
I've been replacing aguments.callee with fn names without deeper investigations, so I might have made some mistakes. Second thing is that enabling strict mode may change code behaviour. It's not happening often, but IIRC there are some edge cases.
Anyway, it needs further investigation.
Note: See
TracTickets for help on using
tickets.
