List Plugin adds extra <br> when making styled text a list

[scott schmitz]

Steps to reproduce

1. you can use the demo - type in 5 lines of text. Break the lines with shift+return

2. Select that text and some more and make all that text bold

3. Select 3 of those lines and click on the list control

Expected result

You will see that extra return characters have been added to the list items

Actual result

The list should be clean with no extra CR's.

Other details (browser, OS, CKEditor version, installed plugins)

This test was run on 4.5.4 This bug was NOT present in version 3.6.6

Related Issues

• #14256

[scott schmitz]

I tested this on Firefox and on Chrome and got the same result

[scott schmitz]

OK, I'll explain with some screen shots.

1. I type in several lines and when I type return I hold down the shift key. See screen shot 1
2. I select all of the text in the field and make it bold - see screen shot 2.
3. I select the text that is one, two, three and click on the unordered list control - see screen shot 3

As you can see it does not look right. I have included shot 4 screen shot which shows how things should look.

thanks,

Scott.

[scott schmitz]

shot 1

[scott schmitz]

shot 2

[scott schmitz]

shot 3

[scott schmitz]

shot 4

[scott schmitz]

Replying to j.swiderski:

Please see attached image.

The only extra "return characters" I have found were list margins added by browser. These margins can be overwritten by defining list rules in contents css e.g. ul {margin:0;}.

I'm closing this issue as invalid. @SSchmitz99 if this is not what you have meant and there are some new lines, please provides exact steps to reproduce this issue and provide a screen shot.

OK, I'll explain with some screen shots.

I type in several lines and when I type return I hold down the shift key. See screen shot 1 I select all of the text in the field and make it bold - see screen shot 2. I select the text that is one, two, three and click on the unordered list control - see screen shot 3 As you can see it does not look right. I have included shot 4 screen shot which shows how things should look.

thanks,

Scott.

[Jakub Ś]

I have removed my previous comment because I have missed the "bold the text" part.

@SSchmitz99 thank you for further explanations - issue is valid, reproducible in all browsers from CKEditor 4.5.0

[Tomasz Jakut]

The problem is caused by changes from ​1f2496, most probably the ​line #395 from core/dom/range.js (not passing toStart as a second argument of node.append method).

[Marek Lewandowski]

Moving tickets to the next milestone.

[Marek Lewandowski]

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

[Marek Lewandowski]

As much as we need it, we won't be able to contain it within upcoming release. Moving to our hi prio todolist.