Ticket #1411 (closed Bug: fixed)

Opened 2 years ago

Last modified 2 years ago

Simple form of combo controls show improper (enabled) state when viewing HTML code

Reported by: MarkWB Owned by:
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Toolbar Version: FCKeditor 2.4.3
Keywords: Review+ Cc:

Description

This is true in both 2.4.3 and 2.5.beta when using IE7 (other browsers not tested). When FCK_TOOLBARITEM_ONLYTEXT is used for anything derived from FCKToolbarSpecialCombo; the state of the control will not be shown in the grayed out disabled state when in Source View mode. (Can be duplicated in 6th example for plugins) I think this is really a flaw in whatever skin is being used. If you find the line (412 if default skin) in the 'fck_editor.css' file of the skin that looks like: 

.SC_FieldDisabled .SC_FieldButton, .SC_FieldDisabled .SC_FieldCaption

and change it to: 

.SC_FieldDisabled .SC_FieldButton, .SC_FieldDisabled .SC_FieldCaption, .SC_FieldDisabled

That fixes it for me.

Attachments

1411.patch Download (1.8 KB) - added by fredck 2 years ago.
Proposal patch

Change History

Changed 2 years ago by fredck

Proposal patch

Changed 2 years ago by fredck

  • keywords HasPatch added
  • version changed from FCKeditor 2.5 Beta to FCKeditor 2.4.3
  • milestone changed from FCKeditor 2.5 to FCKeditor 2.6

The proposed fix breaks the combos in normal mode instead. I've attached a patch for it.

As we are working to stabilize the 2.5 Beta, I'm targeting it to the 2.6 to avoid undesired surprises.

Changed 2 years ago by fredck

  • keywords Review? added; HasPatch removed

Changed 2 years ago by martinkou

  • keywords Review+ added; Review? removed

Changed 2 years ago by fredck

  • status changed from new to closed
  • resolution set to fixed

Fixed with [1715]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.