Ticket #1411 (closed Bug: fixed)

Opened 7 months ago

Last modified 2 months ago

Simple form of combo controls show improper (enabled) state when viewing HTML code

Reported by: MarkWB Assigned to:
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Toolbar Version: FCKeditor 2.4.3
Keywords: Review+ Cc:

Description

This is true in both 2.4.3 and 2.5.beta when using IE7 (other browsers not tested). When FCK_TOOLBARITEM_ONLYTEXT is used for anything derived from FCKToolbarSpecialCombo; the state of the control will not be shown in the grayed out disabled state when in Source View mode. (Can be duplicated in 6th example for plugins) I think this is really a flaw in whatever skin is being used. If you find the line (412 if default skin) in the 'fck_editor.css' file of the skin that looks like: 

.SC_FieldDisabled .SC_FieldButton, .SC_FieldDisabled .SC_FieldCaption

and change it to: 

.SC_FieldDisabled .SC_FieldButton, .SC_FieldDisabled .SC_FieldCaption, .SC_FieldDisabled

That fixes it for me.

Attachments

1411.patch (1.8 kB) - added by fredck on 10/16/07 15:19:45.
Proposal patch

Change History

10/16/07 15:19:45 changed by fredck

  • attachment 1411.patch added.

Proposal patch

10/16/07 15:21:47 changed by fredck

  • keywords set to HasPatch.
  • version changed from FCKeditor 2.5 Beta to FCKeditor 2.4.3.
  • milestone changed from FCKeditor 2.5 to FCKeditor 2.6.

The proposed fix breaks the combos in normal mode instead. I've attached a patch for it.

As we are working to stabilize the 2.5 Beta, I'm targeting it to the 2.6 to avoid undesired surprises.

03/15/08 19:16:01 changed by fredck

  • keywords changed from HasPatch to Review?.

03/18/08 09:29:11 changed by martinkou

  • keywords changed from Review? to Review+.

03/18/08 09:55:18 changed by fredck

  • status changed from new to closed.
  • resolution set to fixed.

Fixed with [1715]. Click here for more info about our SVN system.