Ticket #1475 (closed Bug: fixed)

Opened 2 years ago

Last modified 2 years ago

Resize of dialogs isn't right in standards mode

Reported by: alfonsoml Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Dialogs Version: FCKeditor 2.4.3
Keywords: Cc:

Description

I don't know if it does make any sense to change the code in fckdialog right now as it will be converted to a floating panel, but anyway, the new version should avoid this problems:

If the content loaded in the dialog is rendered in Standards mode then the calculation of the proper height isn't done properly because it uses oInnerDoc.body instead of oInnerDoc.documentElement.

Also, the resizing is only vertical, not fitting automatically widths different than the one specified in the calling code.

And the code there still uses document.all, instead of proper browser detection.

Change History

  Changed 2 years ago by martinkou

  • owner set to martinkou
  • status changed from new to assigned

This ticket is related to #35.

follow-up: ↓ 3   Changed 2 years ago by martinkou

Fixed with [1225] and [1227].

Fred: Should I wait for the floating dialog branch review before closing this ticket as fixed?

in reply to: ↑ 2   Changed 2 years ago by fredck

Replying to martinkou:

Fred: Should I wait for the floating dialog branch review before closing this ticket as fixed?

For the reporter to have a better understanding of the status of the ticket, I believe it is the right thing to have it closed only when the relative fix lands to trunk.

In the mean time, we can maintain the log of the evolution of the ticket with comments, as you have precisely done.

  Changed 2 years ago by fredck

  • component changed from General to UI : Dialogs

  Changed 2 years ago by martinkou

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with #35.

Note: See TracTickets for help on using tickets.