Ticket #1504 (closed New Feature: fixed)

Opened 2 years ago

Last modified 10 months ago

License header review

Reported by: wwalc Owned by: fredck
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed V3ProtoStruct Review+ Cc:

Description

License info in each file takes around 700B.

700B x 30 days x 5000 hits/day x 10 file requests = 1GB/month

I have 6mbit connection so it doesn't affect me that much, but... imho that's just wasting traffic.

Shouldn't we place only a single license.txt file or at least reduce the amount of comments by placing a short link to  http://www.fckeditor.net/license ?

Change History

  Changed 2 years ago by wwalc

  • summary changed from License too long in each file? to License info too long in each file?

  Changed 2 years ago by w.olchawa

  • keywords Confirmed added

  Changed 20 months ago by fredck

  • keywords V3ProtoStruct Discussion added
  • owner set to fredck
  • status changed from new to assigned
  • milestone set to CKEditor 3.0

The copyright must definitely be visible in each file. All the rest is totally optional, but it is important for end users to have ways to clearly identify the license under which the code is distributed when including our code in their software.

Currently, we have the following in the CKEditor prototype branch:

/*
 * CKEditor - The text editor for Internet - http://ckeditor.com
 * Copyright (C) 2003-2008 Frederico Caldeira Knabben
 *
 * == BEGIN LICENSE ==
 *
 * Licensed under the terms of any of the following licenses at your
 * choice:
 *
 *  - GNU General Public License Version 2 or later (the "GPL")
 *    http://www.gnu.org/licenses/gpl.html
 *
 *  - GNU Lesser General Public License Version 2.1 or later (the "LGPL")
 *    http://www.gnu.org/licenses/lgpl.html
 *
 *  - Mozilla Public License Version 1.1 or later (the "MPL")
 *    http://www.mozilla.org/MPL/MPL-1.1.html
 *
 * == END LICENSE ==
 */

What about a radical change to the following?

/*
Copyright (c) 2003-2008, Frederico Caldeira Knabben. All rights reserved.
For licensing, see LICENSE.html or http://ckeditor.com/license
*/

  Changed 20 months ago by fredck

  • summary changed from License info too long in each file? to License header review

  Changed 14 months ago by fredck

  • keywords Review? added; Discussion removed

Ok... that's the final version for it:

/*
Copyright (c) 2003-2008, CKSource - Frederico Knabben. All rights reserved.
For licensing, see LICENSE.html or http://ckeditor.com/license
*/

  Changed 14 months ago by martinkou

  • keywords Review+ added; Review? removed

  Changed 14 months ago by fredck

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [2922] and [2923].

follow-up: ↓ 9   Changed 14 months ago by mosipov

This is a very good approach. Should I adapt the same heading for FCKeditor.Java 2.5 and up?

in reply to: ↑ 8   Changed 10 months ago by fredck

Replying to mosipov:

This is a very good approach. Should I adapt the same heading for FCKeditor.Java 2.5 and up?

We'll have it in the CKEditor integration for Java.

Note: See TracTickets for help on using tickets.