Ticket #1541 (closed Bug: fixed)

Opened 13 months ago

Last modified 3 months ago

Disable auto tag closing in Mediawiki fckeditor extension

Reported by: jaamit Owned by:
Priority: Normal Milestone:
Component: Project : MediaWiki+FCKeditor Version:
Keywords: Fixed Cc:

Description

Hi,

I am using the FCKeditor extension for mediawiki in combination with an extension called ArticleComments which enables guestbook style comments with the inclusion of a <comments /> tag anywhere on a page.

The problem is that FCKeditor automatically changes <comments /> to <comments></comments>, which stops the ArticleComments extension from working properly.

Is there any way to disable this automatic closing of tags so <comments /> stays as it is?

I'm working to quite a strict deadline to provide a customised mediawiki interface for a client and I would really appreciate some speedy assistance

Thanks

Jaamit Durrani jaamit.durrani@…

Attachments

1541.patch (1.0 KB) - added by arczi 3 months ago.

Change History

in reply to: ↑ description   Changed 13 months ago by jaamit

Replying to jaamit:

PS - I have tried adding the following lines to both mediawiki\extensions\FCKeditor\fckeditor_config.js and to mediawiki\extensions\FCKeditor\FCKeditor\fckconfig.js:

FCKConfig.ProtectedTags = 'COMMENTS|COMMENTS/' ; FCKConfig.ProtectedSource.Add( /<comments:.*>/g ) ;

Not sure if the syntax is correct but this does not resolve the problem - <comment/> still changes to <comment></comment>

  Changed 13 months ago by jaamit

OK I have just noticed another bug which makes this problem even more of a nightmare. Everytime a page containing the <comment/> tag is edited (or every time I simply switch between wsywig and wikitext), another set of <comment></comment> tags is added! 10 edits later, you end up with a page full of "Leave a comment..." (from the ArticleComments extension) links!! I REALLY need a way to stop FCKeditor messing with this tag- someone please help.

Jaamit

  Changed 13 months ago by fredck

  • keywords disable auto self closing tags removed
  • priority changed from High to Normal

  Changed 9 months ago by w.olchawa

  • status changed from new to closed
  • resolution set to wontfix

Hi!

If the auto tag closing was disabled it could make even worse damage. Let's say that someone forgets to close the tag than the whole text which appears after the first tag would be formatted incorrectly. It would make things even worse.

  Changed 8 months ago by avatar

  • status changed from closed to reopened
  • resolution wontfix deleted

While the conclusion ("Disable auto tag closing in Mediawiki fckeditor extension") is wrong, the problem should be adressed.

The behaviour of the ArticleComments extension is not unusual. I had the same problem with the Bibwiki extension (http://www.plaschg.net/bibwiki/) which creates a bibliography via the <bibreferences/> tag. This also stop working when editing the article via FCKeditor, because it's converted to <bibreferences></bibreferences> which won't work.

I solved it by taking a look at ticket #1437 - and doing similiar changes to the files mentioned in changeset [1834] to bibreferences (which are there done for references).

Changed 3 months ago by arczi

  Changed 3 months ago by arczi

  • keywords Review? added

  Changed 3 months ago by wwalc

  • keywords Review+ added; Review? removed

  Changed 3 months ago by arczi

  • keywords Fixed added; Review+ removed
  • status changed from reopened to closed
  • resolution set to fixed

Fixed with [2457]

Note: See TracTickets for help on using tickets.