Ticket #1586 (closed Bug: fixed)

Opened 10 months ago

Last modified 6 months ago

[IE] JavaScript error on edit

Reported by: Vincent.cabs Owned by:
Priority: Normal Milestone:
Component: Project : MediaWiki+FCKeditor Version: FCKeditor 2.5 Beta
Keywords: Confirmed IE Cc:

Description

Is anyone able to solve that problem?

I have a major crash with IE 6 SP1 and Mediawiki+FCKeditor.

The crash happens when I change a certain bit of an article and when I press "save" or "wikitext". it is very disturbing as I don't know how to debug that.

You can reproduce the crash by following those steps in IE 6:

1. go on http://mediawiki.fckeditor.net/index.php/TestMyBug : a new page I created

2.. change the title : e.g. remove the ':' 3. click on 'wikitext' or on the 'save' button

... IE crashes !!

info : Windows 2000, IE 6.0.2800 SP1. works fine with Firefox 2

Attachments

bug FCKeditor.jpg (151.8 kB) - added by Vincent.cabs 10 months ago.
IE crashes on a simple Edit
1586.patch (0.6 kB) - added by fredck 10 months ago.
Patch proposal
TC_1586.png (13.1 kB) - added by w.olchawa 7 months ago.

Change History

Changed 10 months ago by Vincent.cabs

IE crashes on a simple Edit

follow-up: ↓ 2   Changed 10 months ago by fredck

  • keywords Pending added; Internet Explorer crash removed
  • priority changed from High to Normal
  • milestone deleted

I was able to consistently reproduce this problem with IE6. It works well with IE7.

It is not an issue with FCKeditor, but with the MediaWiki plugin. I've debugged it, and found the culprit. I'm attaching a possible patch for it.

I haven't tested it. Could you please confirm that it solved the problem?

Changed 10 months ago by fredck

Patch proposal

in reply to: ↑ 1 ; follow-up: ↓ 3   Changed 10 months ago by Vincent.cabs

It works!!!

Thank you sooooo much!

in reply to: ↑ 2 ; follow-up: ↓ 4   Changed 10 months ago by Vincent.cabs

Just one question : how did you find the bug ?

in reply to: ↑ 3   Changed 10 months ago by fredck

  • keywords Pending removed
  • status changed from new to closed
  • resolution set to fixed

Replying to Vincent.cabs:

Just one question : how did you find the bug ?

Well... some intuition helped :) Let's say that I have a long experience on fighting browsers bugs :)

I've committed the fix to the SVN:
http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=27935

  Changed 7 months ago by w.olchawa

#1935 has been marked as DUP

  Changed 7 months ago by w.olchawa

  • status changed from closed to reopened
  • resolution deleted

As for Vincent.cabs suggestion in #1935 I'm reopening this ticket.

follow-up: ↓ 8   Changed 7 months ago by w.olchawa

  • keywords Pending added

I'm not able to reproduce this bug in IE6, but in WIN SP2.

in reply to: ↑ 7   Changed 7 months ago by Vincent.cabs

Replying to w.olchawa:

I'm not able to reproduce this bug in IE6, but in WIN SP2.

Go back to http://mediawiki.fckeditor.net/index.php/TestMyBug. You should be able to reproduce the bug with IE 6. Don't know why. Is there a charset problem ?

  Changed 7 months ago by w.olchawa

  • keywords Confimed IE added; Pending removed
  • summary changed from IE 6 SP1 crashes on edit to [IE] JavaScript erroe on edit

Confirmed in IE6 and IE7. I've attached a screenshot of the error. It's possible that we had a similar bug before but I'm no certain.

Changed 7 months ago by w.olchawa

  Changed 7 months ago by w.olchawa

  • summary changed from [IE] JavaScript erroe on edit to [IE] JavaScript error on edit

  Changed 7 months ago by w.olchawa

  • keywords Confirmed added; Confimed removed

follow-up: ↓ 13   Changed 6 months ago by wwalc

  • status changed from reopened to closed
  • resolution set to fixed

I have committed patch provided by fredck (1586.patch) with [1820] and fixed the "object doesn't support this property or method" with [1821].

Other than that, it seems to be a problem to have two SVN repositories...

in reply to: ↑ 12   Changed 6 months ago by Vincent.cabs

It works, thanks very much !

  Changed 6 months ago by w.olchawa

#2026 has been marked as DUP

Note: See TracTickets for help on using tickets.