Ticket #1607 (closed Task: fixed)

Opened 12 months ago

Last modified 12 months ago

Remove FCKConfig.GeckoUseSPAN

Reported by: alfonsoml Owned by:
Priority: Normal Milestone: FCKeditor 2.6
Component: Core : Styles Version: FCKeditor 2.5
Keywords: Review+ Cc:

Description

With the new Style system the FCKConfig.GeckoUseSPAN setting shouldn't affect the output at all, so it can be removed.

Attachments

1607.patch (3.5 KB) - added by alfonsoml 12 months ago.
Proposed patch

Change History

Changed 12 months ago by alfonsoml

Proposed patch

Changed 12 months ago by alfonsoml

  • keywords Review? added
  • milestone set to FCKeditor 2.6

I've attached the proposed patch. It removes the configuration entries and initializes the editing mode of Gecko to don't use CSS (we will take care of it).

Changed 12 months ago by martinkou

  • keywords Review+ added; Review? removed
  • status changed from new to closed
  • resolution set to fixed

Fixed with [1170].

Click here for more info about our SVN system.

Changed 12 months ago by fredck

  • status changed from closed to reopened
  • resolution fixed deleted

Is there any reason for still calling the styleWithCSS/useCSS commands? They should make no difference for us.

Changed 12 months ago by alfonsoml

I've leave them there just in case the code generated by Gecko with CSS differs slightly from what is expected currently and maybe it does something in the future that isn't handled (I'm expecting that they could only change the behavior of StyleWithCSS, changing the output if it is disabled will bring them lots of bug reports quickly).

But if we are confident about the capabilities of the Style system then we can remove them.

Changed 12 months ago by fredck

  • status changed from reopened to closed
  • resolution set to fixed

According to the Midas documentation, this command defaults to "true". So, other than being irrelevant to us, it is an unneeded "just in case" thing.

Removed with [1176]. I've also removed the "insertBrOnReturn" note from there.

Note: See TracTickets for help on using tickets.