Ticket #1673 (closed Bug: invalid)

Opened 12 months ago

Last modified 11 months ago

Syntax error found in fckstyles.xml file

Reported by: latentdabbler Owned by:
Priority: Normal Milestone:
Component: Core : Styles Version: FCKeditor 2.5
Keywords: Cc:

Description

I found what I think is a syntax error in the fckeditor.xml file.

Lines 64-69 say this:

	<Style name="Marker: Yellow" element="span">
		<Style name="background-color" value="Yellow" />
	</Style>
	<Style name="Marker: Green" element="span">
		<Style name="background-color" value="Lime" />
	</Style>

When I changed them to the following, Firebug stopped showing me an error:

	<Style name="Marker: Yellow" element="span">
		<Attribute name="background-color" value="Yellow" />
	</Style>
	<Style name="Marker: Green" element="span">
		<Attribute name="background-color" value="Lime" />
	</Style>

So, the <Attribute>'s were typed in as <Style>. I just checked the nightly build and it's still this way.

Change History

Changed 11 months ago by alfonsoml

  • status changed from new to closed
  • resolution set to invalid
  • summary changed from Syntax error found in fckeditor.xml file to Syntax error found in fckstyles.xml file

It doesn't look like an error to me. It's specifiying that the Style of the named style "Marker: Yellow" is background-color:yellow. So it ends up generating

<span style="background-color:yellow"></span>

If you change it to Attribute then it does generate

<span background-color="yellow"></span>

which isn't valid html

and I don't see any error in firebug at all.

Note: See TracTickets for help on using tickets.