E.tagName has no properties when using tablecommands plugin.

[keith.pitt]

You get an error when trying to make text bold in a table when you have the "tablecommands" plugin installed.

E.tagName has no properties

FCKEvents(undefined, undefined) ApplyStyle(Object Element=b _StyleDesc=Object IsCore=true GetType_$=1) FCKCoreStyleCommand() FCKToolbarButton() FCKToolbarButtonUI_OnClick(click clientX=0, clientY=0, Object Name=Bold Label=Bold Tooltip=Bold Style=0 State=0) CancelEvent(click clientX=0, clientY=0)

[arczi]

Steps to reproduce:

1. In fckconfig.js add:

	FCKConfig.Plugins.Add( 'tablecommands' );

add 'TableHorizontalSplitCell' to default toolbar

2.Paste in source mode:

<p>&nbsp;</p>
<table width="200" cellspacing="1" cellpadding="1" border="1">
    <tbody>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr>
            <td>&nbsp;</td>
            <td>11111</td>
        </tr>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
    </tbody>
</table>

3.Back to WYSIWIG

4.Click 11111

5.Click Bold. In FF3 (Vista32) you get an error:

oCell.tagName is undefined
http://localhost/edytor/FCKeditor/tags/2.5.1/editor/_source/internals/fcktablehandler_gecko.js
Line 51

51 if ( oCell.tagName.Equals( 'TD', 'TH' ) )
52 aCells[aCells.length] = oCell ;

I attached a simple solution.

[fredck]

The proposed patch fixes the problem, but there a few things to keep attention:

1. Ok, you are filtering now all ( nodeType == 3 ) nodes... but "if ( oCell.tagName..." is actually looking for ( nodeType == 1 ) stuff. What about potential nodeType that are not 3 or 1? So, instead of filtering the buggy part, the more correct and simple approach is simply going right to the point, by doing "if ( oCell.nodeType == 1 && oCell.tagName...".

2. The patch should also contain the changelog entry for it.

3. A small detail... the coding style should follow our standards.

[alfonsoml]

wouldn't it work to just use

oCell.nodeName.Equals( 'TD', 'TH' )

?

(I'm asking that question, just searching for a patch even better)

[arczi]

You're right, it is better solution.

[arczi]

Fixed with [2557]