Ticket #1769 (closed New Feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Improvements to FCKDomTools.GetCurrentElementStyle

Reported by: fredck Owned by: fredck
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: SVN (FCKeditor)
Keywords: Review+ Cc:

Description

I'm attaching a patch with the following improvements for FCKDomTools.GetCurrentElementStyle:

  • There is no need to pass the window in the parameters (this was a Firefox requirement only).
  • Due to the above, FCKDomTools.GetPositionedAncestor is not required to receive the window in the parameters too.
  • Using the getPropertyValue method to retrieve the property value, instead of the default indexer access.
  • In CSS we have "properties", not attributes, so the parameter name could be fixed.

Attachments

1769.patch Download (3.2 KB) - added by fredck 2 years ago.

Change History

Changed 2 years ago by fredck

Changed 2 years ago by fredck

  • keywords Review? added
  • status changed from new to assigned

Changed 2 years ago by alfonsoml

  • keywords Review+ added; Review? removed

It looks better this way

Changed 2 years ago by fredck

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [1384]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.