Opened 17 years ago

Closed 17 years ago

#1891 closed Bug (fixed)

fck_tablecell.html id >< name conflicts

Reported by: Stijn René Cumps Owned by: Alfonso Martínez de Lizarrondo
Priority: Low Milestone: FCKeditor 2.6.4
Component: UI : Dialogs Version: FCKeditor 2.5.1
Keywords: Review+ Cc:

Description

Low priority.

I noticed that a lot of input controls are not consistent with the ID and the Name. Some examples.

<select id="selWordWrap" name="selAlignment"> <select id="selHAlign" name="selAlignment"> <select id="selVAlign" name="selAlignment"> <input id="txtBackColor" type="text" size="8" name="txtCellSpacing"> <input id="txtBorderColor" type="text" size="8" name="txtCellPadding" />

As you can see here, the ID is the correct one, the name is incorrect.

Find this issue on GitHub

Change History (4)

Changed 17 years ago by Alfonso Martínez de Lizarrondo

Attachment: 1891.patch added

Proposed patch

comment:1 Changed 17 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

The name attribute isn't really used in the dialogs (except maybe for the quick upload, so I didn't touch those, and in the link dialog for the chkFeature checkboxes)

The proposed patch removes the rest of names.

comment:2 Changed 17 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:3 Changed 17 years ago by Alfonso Martínez de Lizarrondo

Milestone: FCKeditor 2.6.4
Resolution: fixed
Status: assignedclosed

Fixed with [2374]

Find this issue on GitHub
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy