Ticket #1891 (closed Bug: fixed)

Opened 2 years ago

Last modified 19 months ago

fck_tablecell.html id >< name conflicts

Reported by: estan Owned by: alfonsoml
Priority: Low Milestone: FCKeditor 2.6.4
Component: UI : Dialogs Version: FCKeditor 2.5.1
Keywords: Review+ Cc:

Description

Low priority.

I noticed that a lot of input controls are not consistent with the ID and the Name. Some examples.

<select id="selWordWrap" name="selAlignment"> <select id="selHAlign" name="selAlignment"> <select id="selVAlign" name="selAlignment"> <input id="txtBackColor" type="text" size="8" name="txtCellSpacing"> <input id="txtBorderColor" type="text" size="8" name="txtCellPadding" />

As you can see here, the ID is the correct one, the name is incorrect.

Attachments

1891.patch Download (11.3 KB) - added by alfonsoml 20 months ago.
Proposed patch

Change History

Changed 20 months ago by alfonsoml

Proposed patch

Changed 20 months ago by alfonsoml

  • keywords Review? added
  • owner set to alfonsoml
  • status changed from new to assigned

The name attribute isn't really used in the dialogs (except maybe for the quick upload, so I didn't touch those, and in the link dialog for the chkFeature checkboxes)

The proposed patch removes the rest of names.

Changed 19 months ago by martinkou

  • keywords Review+ added; Review? removed

Changed 19 months ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to FCKeditor 2.6.4

Fixed with [2374]

Note: See TracTickets for help on using tickets.