Ticket #1982 (closed Bug: fixed)

Opened 2 years ago

Last modified 17 months ago

[IE7] Table context menu submenus doesn't appear properly.

Reported by: w.olchawa Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.4
Component: UI : Context Menu Version: FCKeditor 2.4.3
Keywords: Confirmed IE Review+ Cc:

Description

Steps to reproduce:

1. Go to our demo page  http://www.fckeditor.net/demo

2. Insert a table.

3. Right-click inside a cell to activate the context menu

4. Go to a sub-menu e.g. Cell, Row or Column

Notice that the submenu appears not besides the context menu but practically on it.

Expected behavior would be displaying a submenu besides the original context menu.

Tested using 2.6 beta and SVN version on IE7. It works fine in IE6 and FF2.

Attachments

1982.patch Download (3.2 KB) - added by alfonsoml 19 months ago.
Proposed patch
1982_1.patch Download (3.7 KB) - added by alfonsoml 19 months ago.
Patch including RTL handling.
1982_2.patch Download (1.6 KB) - added by martinkou 17 months ago.
Modified Alfonso's patch to support more than 2 submenu levels.
1982_3.patch Download (1.7 KB) - added by martinkou 17 months ago.

Change History

Changed 2 years ago by fredck

  • version changed from FCKeditor 2.6 Beta to FCKeditor 2.4.3
  • milestone set to FCKeditor 2.7

This is not a regression. I've confirmed it with version 2.4.3, so it's not a regression.

Even if annoying, it is not a big issue, fortunately.

Changed 19 months ago by alfonsoml

Proposed patch

Changed 19 months ago by alfonsoml

  • owner set to alfonsoml
  • status changed from new to assigned

I've managed to create a patch that fixes the problem with almost no drawbacks.

The problem is that the submenus are created having the main menu as its parent window, so their dimensions are restricted by that main menu. I've coded a little logic that takes care to increase the size of that panel and so it allows the submenu to have whatever dimensions are needed.

I'm checking now (I wanted to do it earlier but I forgot) that the behaviour with the Hebrew language isn't too nice. I'll have to work on it before requesting review (anyway, if someone has any idea I'll be glad)

Changed 19 months ago by alfonsoml

Patch including RTL handling.

Changed 19 months ago by alfonsoml

  • keywords Review? added
  • component changed from General to UI : Context Menu

Ok, I needed to rest a little to find the solution but now it works fine in all my tests.

The only drawback of the patch is that there's a white area behind the submenu, but I think that it's a very minor thing comparing to how hard is currently to access the submenus in IE7 sometimes (for example if you are at the right side of the screen).

Changed 19 months ago by martinkou

  • keywords Review+ added; Review? removed

Changed 19 months ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to FCKeditor 2.6.4

Fixed with [2386]

Changed 19 months ago by AlfK

  • status changed from closed to reopened
  • resolution fixed deleted

Changed 19 months ago by alfonsoml

  • keywords Review+ removed
  • owner alfonsoml deleted
  • status changed from reopened to new

I have no plans to work on three levels menus as I haven't seen any patch to add such menus or any plugin that uses them.

Maybe someone else wants to spend their time fixing that problem. Clearing out the review so it doesn't show in the default queries also.

Changed 19 months ago by martinkou

  • owner set to martinkou
  • status changed from new to assigned

Changed 17 months ago by martinkou

  • keywords Review? added

It took me a while to figure out what Alfonso's patch was doing, but turns out the modifications needed aren't big.

Changed 17 months ago by martinkou

Modified Alfonso's patch to support more than 2 submenu levels.

Changed 17 months ago by fredck

  • keywords Review- added; Review? removed

The patch looks good. There is just one small detail. Please cleanup the this.RelativeElement property, because it could easily result on memory leak.

Changed 17 months ago by martinkou

Changed 17 months ago by martinkou

  • keywords Review? added; Review- removed

Added the cleanup code.

Changed 17 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 17 months ago by martinkou

Fixed with [2597].

Click here for more info about our SVN system.

Changed 17 months ago by martinkou

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.