Ticket #2024 (closed Bug: fixed)

Opened 2 months ago

Last modified 2 months ago

FCKDialog IE selection error when in source view

Reported by: letssurf Assigned to: martinkou
Priority: High Milestone: FCKeditor 2.6
Component: UI : Dialogs Version: SVN
Keywords: Confirmed IE HasPatch Review+ Cc:

Description

When trying to display a dialog using the new FCKDialog while on IE while in source view an error occurs.

IE says "'selection' is null or not an object"

I managed to track this error down to /fckeditor/editor/_source/internals/fckdialog.js line 112.

I don't understand in internal workings of FCKEditor fully. I have managed to work out that it's due to it trying to access the Editor which isn't about while in source view.

Adding a check for the EditMode and using the EditingArea.Textarea to select the selection seems to fix the problem. I'm not 100% sure this is the correct fix so an FCKEditor core dev will have to read though the patch I've attached.

Attachments

fckdialog_ie_selection_source_view.patch (2.2 kB) - added by letssurf on 03/17/08 13:05:09.
2024.patch (1.3 kB) - added by martinkou on 03/18/08 05:24:20.

Change History

03/17/08 13:05:09 changed by letssurf

  • attachment fckdialog_ie_selection_source_view.patch added.

03/18/08 05:06:04 changed by martinkou

  • owner set to martinkou.
  • status changed from new to assigned.

03/18/08 05:23:50 changed by martinkou

  • keywords changed from dialogs ie selection to Confirmed IE Review?.

Hi letssurf,

Your observations and the general idea of your patch are correct. The patch can be further simplified though. I'm attaching a simplified patch for review.

03/18/08 05:24:02 changed by martinkou

  • keywords changed from Confirmed IE Review? to Confirmed IE HasPatch Review?.

03/18/08 05:24:20 changed by martinkou

  • attachment 2024.patch added.

03/18/08 11:43:33 changed by fredck

  • keywords changed from Confirmed IE HasPatch Review? to Confirmed IE HasPatch Review+.

03/18/08 11:45:09 changed by letssurf

Works for me. Thanks guys :) very fast fix.

03/18/08 20:27:55 changed by martinkou

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed with [1726].

Click here for more info about our SVN system.