FCKDialog IE selection error when in source view

[letssurf]

When trying to display a dialog using the new FCKDialog while on IE while in source view an error occurs.

IE says "'selection' is null or not an object"

I managed to track this error down to /fckeditor/editor/_source/internals/fckdialog.js line 112.

I don't understand in internal workings of FCKEditor fully. I have managed to work out that it's due to it trying to access the Editor which isn't about while in source view.

Adding a check for the EditMode and using the EditingArea.Textarea to select the selection seems to fix the problem. I'm not 100% sure this is the correct fix so an FCKEditor core dev will have to read though the patch I've attached.

[martinkou]

Hi letssurf,

Your observations and the general idea of your patch are correct. The patch can be further simplified though. I'm attaching a simplified patch for review.

[letssurf]

Works for me. Thanks guys :) very fast fix.

[martinkou]

Fixed with [1726].

Click here for more info about our SVN system.