Ticket #2370 (closed Bug: fixed)

Opened 5 months ago

Last modified 3 months ago

MediaWiki 1.13 + FCKeditor - Image button search and preview not working

Reported by: tybeede Owned by:
Priority: Normal Milestone:
Component: Project : MediaWiki+FCKeditor Version: SVN
Keywords: fixed Cc:

Description

Hello folks,

I think this is a bug. I've got the latest release of all the software downloaded from SVN as of 7/15/08. This includes MediaWiki and FCK extension with FCK editor.

I can upload an image file via mediawiki upload and everything works great. The filename gets added to the database and shows up when you click on the "list uploaded files". I can add the image to a wiki page using both the wiki markup lang and the image button.

However, when using the image button I am unable to get any search results or a preview of the image. If I type the name correctly I can insert the image and it shows up like normal. However, I don't get a search result or a preview at any point. After the image is inserted into the page I can right click and edit the image. In this case the preview does pop up in the dialog box.

I followed the install guide at the Mediawiki + FCK editor integration site and everything else works great.

Attachments

2370.patch (0.9 KB) - added by arczi 3 months ago.
2370_2.patch (1.9 KB) - added by arczi 3 months ago.

Change History

  Changed 5 months ago by tybeede

  • component changed from General to Project : MediaWiki+FCKeditor

  Changed 5 months ago by tybeede

  • version set to SVN

  Changed 4 months ago by w.olchawa

  • keywords Pending WorksForMe added

I was unable to reproduce your bug using MW 1.13 and the latest FCKeditor SVN extension. Searching as well as previewing works as expected in IE (6&7) and in FF(2&3). Could you please let us know what browser are you using? Could you also update to the latest version and let us know if the bug still occurs?

Thanks in advance.

Changed 3 months ago by arczi

follow-up: ↓ 5   Changed 3 months ago by arczi

  • keywords Confirmed Review? added; Pending WorksForMe removed

I think it's connected with mysql LOWER() which are ineffective when applied to binary strings (BINARY, VARBINARY, BLOB)

in reply to: ↑ 4   Changed 3 months ago by mrw

arczi's fix works, the bug also affected file searches for me. However, the new patch is indiscriminate with numbers, searching for 53 brings up 55 55 and so on.

  Changed 3 months ago by wwalc

  • keywords Review- added; Review? removed

This fix isn't PostgreSQL compatible.

@mrw: what files exactly do you have there and what are you searching for? I'm asking because "53" is too short.

Changed 3 months ago by arczi

  Changed 3 months ago by arczi

  • keywords Review? added; Review- removed

  Changed 3 months ago by wwalc

Looks good, but when an image is found and selected, it isn't displayed in the editor. This is probably due to a bug introduced in #2223.

When [[Image:FooBar.jpg]] is parsed and changed into image tag to get link to a real image using src attribute:

$originalLink = $parser->parse("[[Image:".$term."]]", $wgTitle, $options)->getText();
if (false == strpos($originalLink, "src=\"")) {
	return "";
}

$srcPart = substr($originalLink, strpos($originalLink, "src=")+ 5);

we don't get there an <img> tag but a link. So if #2223 will be fixed, this ticket can be reviewed properly.

  Changed 3 months ago by wwalc

  • keywords Review+ added; Review? removed

  Changed 3 months ago by arczi

  • keywords fixed added; Confirmed Review+ removed
  • status changed from new to closed
  • resolution set to fixed

Fixed with [2467]

Note: See TracTickets for help on using tickets.