Ticket #238 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Case insensitve onClick for popup-windowns

Reported by: s1738berger Owned by:
Priority: Normal Milestone: FCKeditor 2.4.1
Component: General Version: FCKeditor 2.4
Keywords: Cc:

Description

Hi would be nice if the regex in 'fck_link.js' not only match 'onClick', but also on 'onclick'. I use to clean the prodced HTML-code with HTML Tidy that changes all attributes to lowercase.

Here the part that could be changed: // Accesible popups oRegex.OnClickPopup = new RegExp() ; oRegex.OnClickPopup.compile( "\\s*on[cC]lick=\"\\s*window.open\\(\\s*this\\.href\\s*,\\s*(?:'([']*)'|null)\\s*,\\s*'([']*)'\\s*\\)\\s*;\\s*return\\s*false;*\\s*\"$" ) ; or maybe make the regex case insensitive at all.

Thanks for your work. Stefan

Change History

Changed 3 years ago by fredck

  • status changed from new to closed
  • version set to FCKeditor 2.4
  • resolution set to fixed
  • milestone set to FCKeditor 2.4.1

We have already worked to change the attribute creation to "onclick" with [198]. It was an unfortunate name choice actually.

The problem would be now backward compatibility with links already using onClick, so I'm incorporating your suggestion in the code.

Fixed with [206].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.