Ticket #2387 (closed Bug: fixed)

Opened 12 months ago

Last modified 12 months ago

FF: Bulleted list error with CTRL+A

Reported by: PavelZ Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.3
Component: General Version: SVN (FCKeditor)
Keywords: Confirmed Firefox Review+ Cc:

Description (last modified by fredck) (diff)

Tested with Firefox/2.0.0.16, in the online demo.

With the following source:

<div>aaa</div>
<div>bbb</div>
<div>ccc</div>

In editing mode:

  1. select all (by pressing Ctrl+A)
  2. click "Insert/Remove Bulleted list"

A JS error is thrown and the first line of text is deleted.

Attachments

2387.patch (1.2 KB) - added by martinkou 12 months ago.

Change History

Changed 12 months ago by fredck

  • keywords Confirmed Firefox added
  • summary changed from Bulleted list does not work properly in FF to FF: Bulleted list error with CTRL+A
  • description modified (diff)
  • version set to SVN
  • milestone set to FCKeditor 2.6.3

Confirmed with FF3 also. Ok with IE7, Opera and Safari. It happens with the following source also:

<p>aaa</p>
<p>bbb</p>
<p>ccc</p>

This one causes lost of data, so I'm targeting it the the 2.6.3.

Changed 12 months ago by martinkou

  • owner set to martinkou
  • status changed from new to assigned

Changed 12 months ago by martinkou

  • owner martinkou deleted
  • status changed from assigned to new

This seems to be FCKDomRangeIterator's problem.

If I use the following code for testing:

<div id="1">aaa</div>
<div id="2">bbb</div>
<div id="3">ccc</div>

And then add the following code just before line 93 in editor/_source/commandclasses/fcklistcommands.js:

alert(block.id);

And then perform the bug's test case. You'll see the id of 1 appearing twice. The duplicated block leads to the JavaScript error later.

Changed 12 months ago by martinkou

The bug is found to be caused by lines 138 and 139 in fckdomrangeiterator.js - but the two lines are used to workaround the bug #1717.

Changed 12 months ago by martinkou

Changed 12 months ago by martinkou

  • keywords Review? added

Changed 12 months ago by martinkou

  • owner set to martinkou
  • status changed from new to assigned

Changed 12 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 12 months ago by martinkou

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [2274].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.