Opened 16 years ago
Closed 11 years ago
#2630 closed Bug (fixed)
Empty span tags not removed when using Placeholder plugin
| Reported by: | Niels Noorlander | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | Core : Output Data | Version: | 3.0 |
| Keywords: | HasPatch | Cc: |
Description
When using the placeholder plugin, which is part of the standard FCK download, empty XHTML-style span tags no longer get removed.
For example, enter the following HTML in de source view:
<html dir="ltr">
<head>
<title>Test</title>
</head>
<body>
<span style="color: white" />
</body>
</html>
Switch to WYSIWYG-mode and back to the source. Without the placeholder plugin, the span will be removed. With the plugin enabled, the span will stay, causing unwanted behaviour because of a IE6/7 rendering bug for XHTML span tags.
After some debugging, I've discovered this problem is easily fixed by changing one line in the plugin:
Original code:
FCKXHtml._AppendChildNodes( node, htmlNode, false ) ;
Fix:
node = FCKXHtml._AppendChildNodes( node, htmlNode, false ) ;
And maybe even better;
node = FCKXHtml._AppendChildNodes( node, htmlNode, Boolean( FCKListsLib.NonEmptyBlockElements[ sNodeName ]) ) ;
Ofcourse this fix is not critical to standard FCK functionality, but the placeholder plugin is an interesting example for FCK customization and would be good to fix it.
Kind regards,
Niels Noorlander.
Change History (3)
comment:1 Changed 16 years ago by
| Keywords: | Confirmed added |
|---|---|
| Version: | FCKeditor 2.6.3 → FCKeditor 2.4 |
comment:2 Changed 13 years ago by
| Component: | General → Core : Output Data |
|---|---|
| Keywords: | HasPatch added |
| Version: | FCKeditor 2.4 → 3.0 |
comment:3 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | confirmed → closed |
Not reproducible on 4.2.
Confirmed under 3.6.2Trunk with FullPage Edit sample