Ticket #2653 (closed Bug: fixed)

Opened 16 months ago

Last modified 14 months ago

Changing table properties cannot be undone (undoes the previous action instead)

Reported by: thiloplanz Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.4
Component: UI : Dialogs Version: FCKeditor 2.3.3
Keywords: Confirmed Review+ Cc:

Description

changing table properties does not insert an undo step. The result of this is that the change in properties cannot be undone. The previous action is undone instead.

The attached patch (fck_table.html) will always insert an undo step, which currently only happens when the table is initially created. This seems to fix the problem (the jury is still out on potential negative implications, but it looks safe).

Attachments

fck_table.html.patch Download (0.7 KB) - added by thiloplanz 16 months ago.
patch for fck_table.html (rev 2674)

Change History

Changed 16 months ago by thiloplanz

patch for fck_table.html (rev 2674)

Changed 16 months ago by thiloplanz

  • component changed from General to UI : Dialogs

Changed 16 months ago by arczi

  • keywords Confirmed HasPatch added; table undo removed
  • version changed from FCKeditor 2.6.3 to FCKeditor 2.3.3

Changed 15 months ago by thiloplanz

Changing table cell properties has the same problem, see #2733

Changed 15 months ago by alfonsoml

  • keywords Review? added; HasPatch removed
  • owner set to alfonsoml
  • status changed from new to assigned

As both tickets are so similar I'm providing a single patch that includes both changes. It's just the fix proposed by thiloplanz for each one with a what's new entry.

Changed 14 months ago by martinkou

  • keywords Review+ added; Review? removed

Changed 14 months ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to FCKeditor 2.6.4

Fixed with [2861]. Thanks for the report and patch.

Note: See TracTickets for help on using tickets.