Opened 15 years ago
Closed 15 years ago
#2653 closed Bug (fixed)
Changing table properties cannot be undone (undoes the previous action instead)
| Reported by: | thiloplanz | Owned by: | Alfonso Martínez de Lizarrondo |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6.4 |
| Component: | UI : Dialogs | Version: | FCKeditor 2.3.3 |
| Keywords: | Confirmed Review+ | Cc: |
Description
changing table properties does not insert an undo step. The result of this is that the change in properties cannot be undone. The previous action is undone instead.
The attached patch (fck_table.html) will always insert an undo step, which currently only happens when the table is initially created. This seems to fix the problem (the jury is still out on potential negative implications, but it looks safe).
Attachments (1)
Change History (7)
Changed 15 years ago by
| Attachment: | fck_table.html.patch added |
|---|
comment:1 Changed 15 years ago by
| Component: | General → UI : Dialogs |
|---|
comment:2 Changed 15 years ago by
| Keywords: | Confirmed HasPatch added; table undo removed |
|---|---|
| Version: | FCKeditor 2.6.3 → FCKeditor 2.3.3 |
comment:4 Changed 15 years ago by
| Keywords: | Review? added; HasPatch removed |
|---|---|
| Owner: | set to Alfonso Martínez de Lizarrondo |
| Status: | new → assigned |
As both tickets are so similar I'm providing a single patch that includes both changes. It's just the fix proposed by thiloplanz for each one with a what's new entry.
comment:5 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:6 Changed 15 years ago by
| Milestone: | → FCKeditor 2.6.4 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Fixed with [2861]. Thanks for the report and patch.
Note: See
TracTickets for help on using
tickets.
patch for fck_table.html (rev 2674)