Opened 15 years ago
Closed 15 years ago
#2775 closed Task (fixed)
Implement Paste from Word dialog
| Reported by: | Garry Yao | Owned by: | Martin Kou |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | Core : Output Data | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Confirmed Review+ | Cc: |
Description (last modified by )
This bug cause comments tag content being inserted as codes when switch to 'source' mode after pasting MS-WORD(2003) documents which always contents IE-targeted conditional comments.
- Open an editor instance with 'source' mode and paste the content of attachment 'msword-comments-doc' into 'wysiwyg' mode.
- Switch to 'source' mode
- Expected: 'source' mode contains correct content markups.
- Actual: 'source' mode contains comment tag inner content.
Edit (2009-01-16): This is actually a missing feature.
Attachments (4)
Change History (16)
Changed 15 years ago by
| Attachment: | msword-comments-doc.doc added |
|---|
comment:1 Changed 15 years ago by
| Component: | General → Core : Output Data |
|---|
comment:2 Changed 15 years ago by
| Summary: | plugin:htmlparser didn't exclude comments tags from input streams → core:htmlparser didn't exclude comments tags from input streams |
|---|
comment:3 Changed 15 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | core:htmlparser didn't exclude comments tags from input streams → Implement Paste from Word dialog |
| Type: | Bug → Task |
Do you mean these things left in the beginning of the HTML output?
Normal 0 0 2 false false false MicrosoftInternetExplorer4 /* Style Definitions */ table.MsoNormalTable {mso-style-name:"Table Normal"; mso-tstyle-rowband-size:0; mso-tstyle-colband-size:0; mso-style-noshow:yes; mso-style-parent:""; mso-padding-alt:0cm 5.4pt 0cm 5.4pt; mso-para-margin:0cm; mso-para-margin-bottom:.0001pt; mso-pagination:widow-orphan; font-size:10.0pt; font-family:"Times New Roman"; mso-ansi-language:#0400; mso-fareast-language:#0400; mso-bidi-language:#0400;}
These are actually fragments of <style> and <meta> contents pasted from MS Word. We have a "Paste from Word" dialog in v2 for cleaning up these things, but it isn't ported to v3, yet. So it's not a bug, but rather a missing feature.
comment:4 Changed 15 years ago by
| Keywords: | Confirmed added |
|---|
comment:5 Changed 15 years ago by
| Owner: | set to Martin Kou |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 2775.patch added |
|---|
comment:6 Changed 15 years ago by
| Keywords: | Review? added |
|---|
comment:7 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
- The cleanWord function must be a property of the dialog definition. In this way it's possible to easily replace it.
- The htmlToLoad string must also go into the dialog definition. It doesn't need to blow the core.
- Again... do not overuse CKEDITOR.tools.extend. The settings can be defined each one separately, like CKEDITOR.config.pasteFromWordIgnoreFontFace.
Changed 15 years ago by
| Attachment: | 2775_2.patch added |
|---|
comment:8 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:9 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
I didn't look at this patch in depth, but in the Trac preview, I can note we have an unneeded (function(){})(); holding the _source/plugins/pastefromword/dialogs/pastefromword.js code.
Changed 15 years ago by
| Attachment: | 2775_3.patch added |
|---|
comment:10 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Ah, yes, I forgot to remove the outer closure after removing the local variables.
comment:11 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
reproducing attachment