Opened 15 years ago
Closed 15 years ago
#2907 closed Bug (fixed)
V3: Make it possible to serialize range bookmark
| Reported by: | Frederico Caldeira Knabben | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | |
| Keywords: | Confirmed Review? | Cc: |
Description
The current bookmark implementation saves references to DOM nodes.
We have identified a number of cases where mutations need to be performed to range bookmark nodes, like cloning or innerHTML replacement. In such cases the node references present in the bookmark are not anymore valid, breaking it.
Just like we have in V2, we should have an option to save ID references when needed. They perform a bit slower, but give the flexibility we need for it.
Attachments (2)
Change History (5)
Changed 15 years ago by
| Attachment: | 2907.patch added |
|---|
comment:1 Changed 15 years ago by
| Keywords: | Review? added |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 2907_2.patch added |
|---|
comment:2 Changed 15 years ago by
comment:3 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Martin, I suppose I got a Review+ for the code I've proposed with the first patch so. As your additions look good, I'm committing it.
Fixed with [3059]. Click here for more info about our SVN system.
Note: See
TracTickets for help on using
tickets.
The changes to CKEDITOR.dom makes sense.
But to make serialize-able bookmarks usable by plugins, the changes would have to be propagated upwards to the selection plugin. And of course, the plugins needing it themselves.
Proposing a patch with additional changes to make serialize-able bookmarks usable by indent and list plugins.