Opened 15 years ago
Closed 15 years ago
#3391 closed Bug (fixed)
Table dialog layout review
| Reported by: | Frederico Caldeira Knabben | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Dialogs | Version: | |
| Keywords: | Confirmed IBM Review+ | Cc: | Damian |
Description
The table dialog is the only one that goes out of our design standards, having all labels at the left of the fields instead of above them. We need uniformity here.
Attachments (2)
Change History (9)
comment:1 Changed 15 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 3391.patch added |
|---|
comment:2 Changed 15 years ago by
| Keywords: | Review? added |
|---|
comment:3 Changed 15 years ago by
comment:4 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|---|
| Owner: | changed from Garry Yao to Frederico Caldeira Knabben |
| Status: | assigned → new |
The changes are mostly ok. I'll be going a bit further, by removing superfluous code from the dialog definition, as well as trying to make it look a bit better.
Changed 15 years ago by
| Attachment: | 3391_2.patch added |
|---|
comment:5 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|---|
| Status: | new → assigned |
comment:6 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Note: See
TracTickets for help on using
tickets.
Beside the table layout changes, the patch also introduce two adjustment to the dialog system: