Opened 15 years ago
Closed 15 years ago
#3512 closed Bug (fixed)
Non-namespaced css class names
| Reported by: | Tobiasz Cudnik | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description
There are many non-namespaced css class names in dialog.css and those are:
- disabled
- dark_background
- LightBackground
- DarkBackground
- hand
- Hand
- centered
- BtnReset
- BtnUnlocked
- BtnLocked
- ImagePreviewBox
- ImagePreviewLoader
- LightBackground
- FlashPreviewBox
I assume those are some legacy classes, but since dialog isn't placed inside an iframe, this can result in some serious complications.
Attachments (2)
Change History (9)
comment:1 Changed 15 years ago by
| Keywords: | Confirmed added |
|---|---|
| Milestone: | CKEditor 3.x → CKEditor 3.0 |
comment:2 Changed 15 years ago by
| Owner: | set to Tobiasz Cudnik |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 3512.patch added |
|---|
comment:3 Changed 15 years ago by
| Keywords: | Review? added |
|---|
This patch fixes all classnames, but there are still IDs left. Now the question is should they be also fixed and whats the naming convention (if different). They are used in couple of places in source code.
comment:4 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The changes to the smiley dialog seems to be duplicate of #3492. Besides, there's still a class="hand" in the smiley dialog.
Changed 15 years ago by
| Attachment: | 3512_2.patch added |
|---|
comment:5 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:6 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Note: See
TracTickets for help on using
tickets.
I would make it fixed for the 3.0, so the impact on skins development will be less drastic.
Other than the "cke_" prefix, the styles names should follow the new naming schema having all lowercased with words separated by underscore.