Ticket #4725 (closed Bug: fixed)

Opened 4 months ago

Last modified 3 months ago

hitting return after html comment produces an error "t.getName is not a function"

Reported by: tyler45 Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Enter Key Version: SVN (CKEditor)
Keywords: Confirmed Review+ Cc:

Description

hi,

when a paragraph ends in an html comment, hitting the enter key with the cursor positioned at the end of this paragraph (to create a new paragraph) throws an error "t.getName is not a function" (line 29 ckeditor.js).

<p>Any old para.<!-- any old comment --></p>

Windows Vista SP2 FF 3.5.5

Attachments

4725.patch Download (461 bytes) - added by garry.yao 4 months ago.
4725_2.patch Download (488 bytes) - added by garry.yao 4 months ago.

Change History

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • status changed from new to assigned
  • component changed from General to UI : Enter Key
  • owner set to garry.yao
  • version set to SVN (CKEditor)
  • milestone set to CKEditor 3.1
  • keywords Confirmed Review? added

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed

Please use the type property to check the node type. I know it'll add 5 bytes more to the code, but we have already understood that using methods to check for node types is a bad practice.

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

Changed 3 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 3 months ago by garry.yao

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [4596].

Note: See TracTickets for help on using tickets.