#4772 closed Bug (fixed)
Links remain default color when painting with 'text-color'
| Reported by: | Sa'ar Zac Elias | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.2 |
| Component: | Core : Styles | Version: | 3.5.3 |
| Keywords: | Cc: |
Description
To Reproduce:
- open the online demo or a nightly build sample.
- Select a sentence that contains a link and paint it in another color.
- notice that the sentence was painted but the link wasn't.
-repeat the reproduction, just instead of a full sentence, select just a link.
this is the normal behavior of the browser, but when the end-user paints a link he expects it to be painted. to fix this issue, the styled span should go inside the A tag and not out of it.
Attachments (1)
Change History (13)
comment:1 Changed 14 years ago by
| Keywords: | Confirmed added |
|---|---|
| Milestone: | → CKEditor 3.2 |
Changed 14 years ago by
| Attachment: | 4772.patch added |
|---|
comment:4 Changed 14 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → assigned |
Ticket test added at : source:CKEditor/trunk/_test/tt/4772/1.html
comment:5 Changed 14 years ago by
| Keywords: | Review? added |
|---|
Ticket Test added at :
http://ckeditor.t/tt/4772/1.html.
comment:6 Changed 14 years ago by
Instead of modifying the entire DTD for this specific case, proposing of introducing a special filter function that determinate the style's own valid parent/child element.
comment:7 Changed 14 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
That's a wonderful idea. Congratulations.
comment:8 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
| Version: | 3.0.1 → SVN (CKEditor) |
Fixed with [5009].
comment:9 follow-up: 10 Changed 13 years ago by
| Keywords: | Confirmed Review+ removed |
|---|---|
| Version: | SVN (CKEditor) - OLD → 3.5.3 (SVN - trunk) |
This fix doesn't change the color of the link underline, just the text. If you go to the demo site (http://ckeditor.com/demo) and change one of the links to red, you get red text with a blue underline.
The better fix would have been to just apply the style to the tag itself: <a style="color: #FF0000".
comment:10 Changed 13 years ago by
Replying to Mack:
This fix doesn't change the color of the link underline, just the text. If you go to the demo site (http://ckeditor.com/demo) and change one of the links to red, you get red text with a blue underline.
The better fix would have been to just apply the style to the tag itself: <a style="color: #FF0000".
We'd like not to mix styles in one tag (a), even this sounds a little bit imperfectness, it should be ok for most of the case.
comment:11 Changed 13 years ago by
Regardless of how it is implemented, can a fix be provided for that problem? Several of our customers are complaining about their multi-colored links.
If not, I looked at changeset 5009 to see where the original fix was made, but I couldn't find that same code in newer releases. Could you point me the relevant spot in the trunk version? thanks.
comment:12 Changed 13 years ago by
#7212 opened for your requirement, it will not be a small change for now.
Feature alignment with #923 of v2.