Opened 14 years ago
Closed 14 years ago
#4857 closed Bug (fixed)
Flash dialog - undefined values in "Properties" -> "Align"
| Reported by: | Wiktor Walc | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | UI : Dialogs | Version: | 3.0.2 |
| Keywords: | Confirmed Review+ | Cc: |
Description
To reproduce:
- Open Flash Dialog
- Go to "Properties -> Align"
- Click on the select box, there are 8 undefined values, only left and right are available.
Attachments (2)
Change History (11)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
| Summary: | Flash dialog - undefined falues in "Properties" -> "Align" → Flash dialog - undefined values in "Properties" -> "Align" |
|---|
comment:3 Changed 14 years ago by
| Component: | General → UI : Dialogs |
|---|---|
| Owner: | set to Garry Yao |
| Status: | new → assigned |
comment:4 Changed 14 years ago by
We may have this feature aligned with the new usage we have in the Image dialog, using the style attribute.
comment:5 Changed 14 years ago by
| Keywords: | Review? added |
|---|
Same treatment with the image dialog's Align field was ported here.
Changed 14 years ago by
| Attachment: | 4857.patch added |
|---|
comment:6 Changed 14 years ago by
| Keywords: | Review- added; Review? removed |
|---|
:/ at a first look into the ticket I was sure the Flash dialog was simply using the Image dialog alignment language entries (and it is), and that the Flash entries for it were "missing" in the lang files. But, looking at the patch, I had the unexpected surprise to see that the Flash entries are also there.
The patch is quite good, but there are other things that we also need to address (like having a better alignment preview on WYSIWYG mode). So, let's make this ticket simpler, by only using the proper editor.lang.flash entries for the options without changing much the dialog definition.
Then, please open a new ticket for "enhancements to Flash alignment", attaching the ticket you have just provided. Feel free to target it to the 3.3.
comment:7 Changed 14 years ago by
| Keywords: | Review? added; Review- removed |
|---|
please open a new ticket for "enhancements to Flash alignment", attaching the ticket you have just provided. Feel free to target it to the 3.3
#4878 is opened for.
Changed 14 years ago by
| Attachment: | 4857_2.patch added |
|---|
comment:8 Changed 14 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
(regression)