Port doctype samples from FCKeditor

[Alfonso Martínez de Lizarrondo]

Port the samples 14, 15 and 16 to show how to generate XHTML, HTML 4 or legacy HTML for flash.

[Alfonso Martínez de Lizarrondo]

Improved documentation

[Alfonso Martínez de Lizarrondo]

Proposed XHTML sample

[Alfonso Martínez de Lizarrondo]

The 5024.html file is documentation for some of the options that were missing and I needed to find.

The sample file it's a port from FCKeditor. It has three problems #5150, #5152 and using the SVN, the call to CKEDITOR.stylesSet.add or CKEDITOR.addStylesSet inline fails. In that aspect, I think that when #4973 is applied to the release version, the people that have CKEDITOR.addStylesSet calls inline will get an error, but that's for another day. I need some rest.

The review is mainly for the doc patches as I might have made some mistake, but any comment about the sample is welcome.

[Alfonso Martínez de Lizarrondo]

Documentation added with [5155]

[Alfonso Martínez de Lizarrondo]

Updated XHTML sample

[Alfonso Martínez de Lizarrondo]

The new XHTML sample should work properly after applying #5150 and #5152

[Garry Yao]

Combo items are not correctly styled.

[Alfonso Martínez de Lizarrondo]

Filed #5292 for that problem

In the new patch I'm using the pluginsLoaded event to add the stylesSet data correctly.

[Alfonso Martínez de Lizarrondo]

Revised patch

[Garry Yao]

Let's exclude the style preview problem which could be later fixed by #5292 instead.
I'm still confused about the reason why keeping 'my_styles' in the main file? Considering the fact that 'pluginsLoaded' stuff is a hack, we should not have it appear in such a sample page.

[Alfonso Martínez de Lizarrondo]

The idea is to show how to define the styles without an extra file/request. The problem is that using the _source files if we put the CKEDITOR.stylesSet call in the main script it will generate an error because the file hasn't been loaded at that moment.

That won't happen in the release version, but we need to test it in _source so I thought to put it this way. Do you have another idea? I think that it's interesting to provide the full sample with some custom styles.

[Garry Yao]

If the possibility of adding combo styles as literal is important, then we should think about duck typing 'CKEDITOR.config.stylesCombo_stylesSet':

/**
 * The "styles definition set" to load into the styles combo. The styles may
 * be defined in the page containing the editor, or can be loaded on demand
 * from an external file when opening the styles combo for the fist time. In
 * the second case, if this setting contains only a name, the styles definition
 * file will be loaded from the "styles" folder inside the stylescombo plugin
 * folder. Otherwise, this setting has the "name:url" syntax, making it
 * possible to set the URL from which loading the styles file.
 * @type String|Array
 * @default 'default'
 * @example
 * // Load from the stylescombo styles folder (mystyles.js file).
 * config.stylesCombo_stylesSet = 'mystyles';
 * @example
 * // Load from a relative URL.
 * config.stylesCombo_stylesSet = 'mystyles:/editorstyles/styles.js';
 * @example
 * // Load from a full URL.
 * config.stylesCombo_stylesSet = 'mystyles:http://www.example.com/editorstyles/styles.js';
 * @example
 * // Load from a list of definitions.
 * config.stylesCombo_stylesSet = [
 *  { name : 'Strong Emphasis', element : 'strong' },
 * { name : 'Emphasis', element : 'em' }, ... ];
 */
CKEDITOR.config.stylesCombo_stylesSet = 'default';

[Alfonso Martínez de Lizarrondo]

Revised patch

[Alfonso Martínez de Lizarrondo]

That's a good idea because it's simple and matches the behavior of the toolbar. I've created #5352 for it and the new patch here uses that approach.

[Garry Yao]

Depend on #5352.

[Alfonso Martínez de Lizarrondo]

XHTML sample included with [5302]

[Alfonso Martínez de Lizarrondo]

HTML sample

[Alfonso Martínez de Lizarrondo]

The new sample shows how to use fonts and output images with dimensions as attributes instead of styles (some mails don't accept styles)

[Garry Yao]

Color values in RGB doesn't get converted into RRGGBB on attribute thus font fore/back colors doesn't display in IE.

[Alfonso Martínez de Lizarrondo]

That problem is #1653. I'll try to fix it.

[Alfonso Martínez de Lizarrondo]

Revised patch

[Alfonso Martínez de Lizarrondo]

I've included in the sample the function to convert rgb() colors so we can publish the sample without further delays.

[Frederico Caldeira Knabben]

Well... I think people will not really use this one as a sample, but as a template for code snippet, because it looks so complex. But anyway, some people may find it useful.

[Garry Yao]

The problem is still there, when applying the 'Red' font color.

[Garry Yao]

Replying to alfonsoml:

That problem is #1653. I'll try to fix it.

Consistency output of color pattern is not a priority now.

[Alfonso Martínez de Lizarrondo]

Fixed RGB issues with #5676. I did misunderstood the previous comments.

[Alfonso Martínez de Lizarrondo]

HTML sample added with [5491]. Flash for the next version.

[Alfonso Martínez de Lizarrondo]

Flash sample

[Alfonso Martínez de Lizarrondo]

I had the Flash sample ready since some time ago, but it was pending to change the graphics in the flash file to put CKEditor instead of FCKeditor. I've realized that it could take too long for me to install the flash compiler just for this task, so I'm asking for review of the sample itself and hope that someone else can change the .fla and create a new .swf file.

[Sa'ar Zac Elias]

Updated the logo.

[Garry Yao]

'Send to Flash' doesn't work for me.

[Alfonso Martínez de Lizarrondo]

Yes, the new swf seems to be missing something because it doesn't work, but the previous version works correctly.

[Sa'ar Zac Elias]

Let's try this one.

[Garry Yao]

Nice done, only to fix the typo from index.html to 'Output for Flash'.

[Sa'ar Zac Elias]

Fixed with [5983].

[Sa'ar Zac Elias]

Changelog entry added with [5984].