Opened 14 years ago

Closed 14 years ago

#6043 closed Bug (fixed)

BIDI: When we apply RTL direction to a right aligned Paragraph, Paragraph is not moved to left & Alignment of Paragraph is not changed

Reported by: Satya Minnekanti Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: 3.3
Keywords: IBM Cc: Damian, joek, jamcunni@…

Description

To reproduce the defect:

  1. Open Ajax sample.
  1. Type some text, keep the cursor in the paragraph and click on Align Right icon in the Tool bar.
  1. See that paragraph is moved to right and Align Right icon is selected in the Tool bar.
  1. keep the cursor in the Paragraph and click on RTL icon in the Tool bar.

Expected Result:

See that paragraph is moved to left and Align Left icon is selected in the Tool bar.

Actual Result:

Paragraph is staying on the right instead of moving to left & Alignment of Paragraph is also not changed & it is still shown as Right Aligned.

Attachments (2)

6043.patch (1.5 KB) - added by Tobiasz Cudnik 14 years ago.
6043_2.patch (1.5 KB) - added by Tobiasz Cudnik 14 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 14 years ago by Frederico Caldeira Knabben

Keywords: Discussion added

I'm quite unsure about this one. The fact is that alignment is a "formatting" feature, while BiDi is a "semantics" feature.

If the user "formatted" the text to be at right, much probably s/he just wants it at right, no matter the language direction.

Opening a discussion around it.

comment:2 Changed 14 years ago by Garry Yao

Hold the same opinion with Fred also, alignment has nothing to do with direction.

comment:3 Changed 14 years ago by Damian

I would not say that alignment has nothing to do with direction. There is a reason why the default rendering in browsers in the following example is right aligned :

  <p dir="rtl">Test</p>

The moment that a user decides that something needs to be RTL, the default expectation is that the content will become right aligned. Agreed, alignment can always be overridden by the user, after they have set the direction.

comment:4 Changed 14 years ago by James

Cc: jamcunni@… added

comment:5 Changed 14 years ago by Tobiasz Cudnik

Keywords: Discussion removed
Owner: set to Tobiasz Cudnik
Status: newassigned

I don't see a difference between mirroring margins and mirroring alignment when changing the direction.

I think we should have this missing feature in 3.4.2.

Changed 14 years ago by Tobiasz Cudnik

Attachment: 6043.patch added

comment:6 Changed 14 years ago by Tobiasz Cudnik

Status: assignedreview

comment:7 Changed 14 years ago by Tobiasz Cudnik

Status: reviewreview_failed

Changed 14 years ago by Tobiasz Cudnik

Attachment: 6043_2.patch added

comment:8 Changed 14 years ago by Tobiasz Cudnik

Status: review_failedreview

comment:9 Changed 14 years ago by Tobiasz Cudnik

Milestone: CKEditor 3.4.2

comment:10 Changed 14 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:11 Changed 14 years ago by Garry Yao

'config.justifyClasses' is not working under the patch, while it should handled separately at #6510.

comment:12 Changed 14 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [5997].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy