Open properties dialog when double clicking on objects

[Frederico Caldeira Knabben]

The relative dialog should open when double clicking on objects like images, anchors, flash, form buttons or even tables (in the border... IE only I guess).

[Artur Formella]

This is only an idea + working example. Is it good way?

[Frederico Caldeira Knabben]

The idea is good. But of course, the patch is still quite incomplete, as we need to enable it for all kinds of objects we support.

[Alfonso Martínez de Lizarrondo]

I like the idea, but it will give an error if the contextMenu plugin isn't available.

[Alfonso Martínez de Lizarrondo]

With my previous comment I just expected to protect the reading of editor.contextMenu._.listeners because that solution was clever and didn't mean extra work.

This new patch means that it's possible to use this feature even if the contextmenu plugin is removed, but I'm not sure if it's worth the extra work. I would like to hear the opinions from someone else.

A benefit of this approach is that there won't be problems if any extra context menu is added.

[Garry Yao]

The behavior on 'dbclick' should be distinguished from which on 'contextmenu', e.g. 635_2.patch opens table dialog when double clicking inside cell, which is wrong.
Beside, the detection mechanism should be simplified, where dialog should simply declare a listener of one param - element, and it would be better the 'wysiwyg' plugin's responsibility to hold such listeners instead of 'dialog' plugiin.

[Minh Nguyen]

New patch with simple detection

[Garry Yao]

There's a misunderstanding here Minh, with 635_4.patch, other dialogs are not able to register to this behavior, perhaps it's better to demonstrate my idea with a patch.
Beside, considering that block element like table/form are just hard to get double-clicked, we should just leave them for now and proposing some other usability feature to achieve the goal, e.g. by double clicking elements path bar item, but it's out the scope of this ticket.

[Garry Yao]

It's not good for image plugin to handle all fake elements' dialog, instead it should be the original dialog, e.g. anchor, flash to detect the fake element.

if ( element.is( 'img' ) )
 evt.data.dialog =  realElement ? realElement : 'image';

Besides, other dialogs like form fields are missing from the patch.

[Garry Yao]

Flash dialog is still missing.

[Minh Nguyen]

add missing flash detection

[Garry Yao]

The patch couldn't be applied on 3.3.x branch where it should be committed, please include the 'hiddenfield' into it also and remove the table cell registration, since it's quite often that people click inside table cell just to highlight a word.

[Minh Nguyen]

ticket #4056 had resolved problem with 'hiddenfield'.

[Garry Yao]

This feature should go into 3.3.x branch when committing.

[Minh Nguyen]

Fixed with [5378].