Ticket #635 (assigned New Feature)

Opened 3 years ago

Last modified 3 days ago

Open properties dialog when double clicking on objects

Reported by: fredck Owned by: m.nguyen
Priority: Normal Milestone: CKEditor 3.3
Component: General Version:
Keywords: Confirmed Review- Cc:

Description

The relative dialog should open when double clicking on objects like images, anchors, flash, form buttons or even tables (in the border... IE only I guess).

Attachments

635.patch Download (1.4 KB) - added by arczi 12 months ago.
635_2.patch Download (1.5 KB) - added by m.nguyen 3 weeks ago.
635_3.patch Download (10.2 KB) - added by m.nguyen 8 days ago.

Change History

Changed 2 years ago by w.olchawa

  • keywords Confirmed added

Changed 12 months ago by arczi

  • owner set to arczi
  • status changed from new to assigned

Changed 12 months ago by arczi

Changed 12 months ago by arczi

  • keywords Review? added

This is only an idea + working example. Is it good way?

Changed 11 months ago by fredck

  • milestone changed from CKEditor 3.0 to CKEditor 3.1

Changed 8 months ago by arczi

  • owner arczi deleted
  • status changed from assigned to new

Changed 6 months ago by fredck

  • keywords Review- added; Review? removed
  • milestone changed from CKEditor 3.1 to CKEditor 3.2

The idea is good. But of course, the patch is still quite incomplete, as we need to enable it for all kinds of objects we support.

Changed 2 months ago by fredck

  • milestone changed from CKEditor 3.2 to CKEditor 3.3

Changed 3 weeks ago by m.nguyen

Changed 3 weeks ago by m.nguyen

  • owner set to m.nguyen
  • status changed from new to assigned

Changed 3 weeks ago by m.nguyen

  • keywords Review? added; Review- removed

Changed 3 weeks ago by alfonsoml

  • keywords Review- added; Review? removed

I like the idea, but it will give an error if the contextMenu plugin isn't available.

Changed 8 days ago by m.nguyen

Changed 8 days ago by m.nguyen

  • keywords Review? added; Review- removed

Changed 8 days ago by alfonsoml

With my previous comment I just expected to protect the reading of editor.contextMenu._.listeners because that solution was clever and didn't mean extra work.

This new patch means that it's possible to use this feature even if the contextmenu plugin is removed, but I'm not sure if it's worth the extra work. I would like to hear the opinions from someone else.

A benefit of this approach is that there won't be problems if any extra context menu is added.

Changed 3 days ago by garry.yao

  • keywords Review- added; Review? removed

The behavior on 'dbclick' should be distinguished from which on 'contextmenu', e.g. 635_2.patch opens table dialog when double clicking inside cell, which is wrong.
Beside, the detection mechanism should be simplified, where dialog should simply declare a listener of one param - element, and it would be better the 'wysiwyg' plugin's responsibility to hold such listeners instead of 'dialog' plugiin.

Note: See TracTickets for help on using tickets.