#6662 closed Bug (fixed)
Lists copied from Word are not pasted properly.
| Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.3 |
| Component: | Plugin : Paste from Word | Version: | |
| Keywords: | IBM Firefox | Cc: | Damian, joek, james, c, lynne_kues@… |
Description
Copy the lists from the Attached document and paste in to the Editor using Paste from Word dialog.
Issue 1:
when we have pasteFromWordRemoveFontStyles & pasteFromWordRemoveStyles set to true Numbered and bulleted lists are pasted properly but they are shown as paragraphs instead of list items.when you keep the cursor in one of the list items Numbered/Bulleted list icons are not highlighted.
keep the cursor at the end of one of the list item and press Enter
Expected Result: A new List item should be started.
Actual Result: A new Paragraph is started.
Issue 2:
when we have pasteFromWordRemoveFontStyles & pasteFromWordRemoveStyles set to false Numbers & bullets for the top level list items are missing.when you keep the cursor in one of the list items Numbered/Bulleted list icons are not highlighted.
keep the cursor at the end of one of the list item and press Enter
Expected Result: A new List item should be started.
Actual Result: A new Paragraph is started.
I am attaching Screenshot of the 2 issues.
Attachments (11)
Change History (37)
Changed 14 years ago by
| Attachment: | This is a line of text.doc added |
|---|
Changed 14 years ago by
Changed 14 years ago by
| Attachment: | lists pasted properly but shown as paragraphs issue1.jpg added |
|---|
comment:1 Changed 14 years ago by
| Component: | General → Core : Pasting |
|---|---|
| Keywords: | Firefox added |
| Milestone: | → CKEditor 3.4.3 |
| Status: | new → confirmed |
comment:2 Changed 14 years ago by
| Owner: | set to Tobiasz Cudnik |
|---|---|
| Status: | confirmed → assigned |
Changed 14 years ago by
| Attachment: | 6662.patch added |
|---|
comment:4 Changed 14 years ago by
| Status: | assigned → review |
|---|
This patch fixes attached TC and 2 different ones i've checked. It tries to reuse existing filter mechanisms to reduce new code size.
Additionally one list merging bug has been fixed (L412).
Changed 13 years ago by
comment:5 Changed 13 years ago by
| Status: | review → review_failed |
|---|
The structure detecting approach proposed by the patch is quite unstable, attaching the document that doesn't work with it.
Changed 13 years ago by
| Attachment: | 6662_2.patch added |
|---|
comment:6 Changed 13 years ago by
| Status: | review_failed → review |
|---|
The margin-to-indentation logic causes problems with the attached document. I've aligned a list creation way with a list destruction, so now we have better results, although it's still not perfect.
Changed 13 years ago by
| Attachment: | 6662_3.patch added |
|---|
comment:7 follow-up: 19 Changed 13 years ago by
I've added support for the "MsoListParagraph" class, which lack of caused problems with Office 2010, although i can't yet check it, as i'm missing access to this version. But it should work.
comment:8 Changed 13 years ago by
| Keywords: | HasPatch added |
|---|---|
| Milestone: | CKEditor 3.4.3 → CKEditor 3.5.1 |
We should hold with this ticket as we've already had active communication result from Mozilla on this issue and it has a high possibility of getting fixed by them.
comment:9 Changed 13 years ago by
| Status: | review → review_failed |
|---|
As the fix is already landed on MineField, we should simply add one code path to detect "mso-list：Ignore" as in what we did in IE.
comment:10 Changed 13 years ago by
| Cc: | james c lynne_kues@… added; James removed |
|---|
Changed 13 years ago by
| Attachment: | bullets.docx added |
|---|
comment:11 Changed 13 years ago by
In addition to list items being transformed to <p> tags, we are also seeing issues with margins not being preserved and bullets not transforming properly. Open the bullets.docx attachment, select all, copy, paste into FF editor. List item margins are not maintained, bullets are not transformed properly. FF 3.6.12. If this is not the same issue, let me know, and I will open a separate defect. Thanks.
comment:12 Changed 13 years ago by
I cannot verify that this has been fixed in FF 3.6.14 pre, i think we still need a patch if this won't be included in 3.x release line.
@lynne_kues: your problems and included TC doc seems related to this one.
Changed 13 years ago by
| Attachment: | 6662_4.patch added |
|---|
comment:13 Changed 13 years ago by
| Owner: | changed from Tobiasz Cudnik to Garry Yao |
|---|---|
| Status: | review_failed → review |
I cannot verify that this has been fixed in FF 3.6.14 pre,
The Mozilla fix arrives in only FF4, and this regression works fine before FF3.6, so I guess the best option for us is just to have a patch for FF4.
comment:14 Changed 13 years ago by
| Milestone: | CKEditor 3.5.1 → CKEditor 3.5.2 |
|---|
Just a note that the third patch provided by Tobiasz does not work with bullets.docx.
comment:15 Changed 13 years ago by
| Status: | review → review_passed |
|---|
comment:16 Changed 13 years ago by
| Keywords: | HasPatch removed |
|---|---|
| Resolution: | → fixed |
| Status: | review_passed → closed |
Fixed with [6545], hopefully we have FF4 very soon.
comment:17 Changed 13 years ago by
This issue is not fixed. I could still reproduce the issues on nightly build.
comment:18 Changed 13 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Having this fixed for FF4 only is not a solution. FF3 will still be with us for some good time.
Changed 13 years ago by
| Attachment: | 6662_5.patch added |
|---|
comment:19 Changed 13 years ago by
| Status: | reopened → review |
|---|
Replying to tobiasz.cudnik:
I've added support for the "MsoListParagraph" class...
Let's consider this a fall back approach for FF3.6.
comment:20 Changed 13 years ago by
| Status: | review → review_failed |
|---|
It's nice to see that a FF3 workaround was not so hard to have. At least for basic support.
There is just one issue with the patch though. We have an empty try/catch at line 1133 now. I think it's by mistake.
Changed 13 years ago by
| Attachment: | 6662_6.patch added |
|---|
comment:21 Changed 13 years ago by
| Status: | review_failed → review |
|---|
comment:22 Changed 13 years ago by
| Status: | review → review_passed |
|---|
comment:23 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6585].
comment:24 Changed 13 years ago by
This issue is still reproducible on latest version of firefox 3.6.15 or 3.6.16. Could you please re open this ticket
comment:25 Changed 13 years ago by
As said it's not a fully functional solution on FF3.x, please open new tickets for any other findings instead.
comment:26 Changed 10 years ago by
| Component: | Core : Pasting → Plugin : Paste from Word |
|---|
Two issues are all due to a recent Firefox update that cause list paste stops working now, we're still under investigation.