BIDI: BiDi buttons do not work on a list that is inside a blockquote

[James]

Steps to reproduce the defect:

1. Open the Ajax sample.
2. Create a Numbered List.
3. Select the Numbered List & click the RTL icon.
4. Select the list & click Blockquote.
5. Click on the LTR icon.

Expected: LTR language direction is applied to the Numbered List. The list appears on the left of the editor. The List is inside a Blockquote.

Actual: Nothing happens. The list remains RTL.

[Garry Yao]

I think we simply apply the direction on the inner most block container (guard elements), in this case when user would like to instead apply it on an outer container, e.g. in this case he want to apply it to "blockquote", he can achieve that with the elements path bar (by first click on the blockquote button).

[Tobiasz Cudnik]

This is yet another case of the "apply to parent when all children selected" from BiDi cases, which is a feature.

Check this TC:

<blockquote>
	<p>
		a</p>
	<ul>
		[<li>
			1</li>
		<li>
			2</li>
		<li>
			3</li>]
	</ul>
	<p>
		b</p>
</blockquote>

[Sa'ar Zac Elias]

Please update the patch.

[Garry Yao]

6728_3.patch doesn't work for the original TC.

[Garry Yao]

Replying to tobiasz.cudnik:

This is yet another case of the "apply to parent when all children selected" from BiDi cases, which is a feature.

Check this TC:

<blockquote>
	<p>
		a</p>
	<ul>
		[<li>
			1</li>
		<li>
			2</li>
		<li>
			3</li>]
	</ul>
	<p>
		b</p>
</blockquote>

I don't get the point, how does 6728_2.patch fail for the patch?

[Tobiasz Cudnik]

Please ignore my previous TC. 6728_2.patch also doesn't work with current trunk, but even if it would we can't accept such change because of ​this TC.

I'm sending new approach which fixes the problem with a quite small change.

[Garry Yao]

6728_4.patch indeed covers a bug, while having no benefit to the ticket bug itself, I still insist on applying dir on the innermost block limit, as that's the easiest way to avoid further bugs caused by differential direction on nested block limits.

Regard your cited ​TC, I think we could safely remove "tr" from guard elements.

[Sa'ar Zac Elias]

Using the following content and selection:

<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
	<tbody>
		<tr>
			[<td>
				aa</td>
			<td>
				bb</td>]
		</tr>
		<tr>
			<td>
				&nbsp;</td>
			<td>
				&nbsp;</td>
		</tr>
		<tr>
			<td>
				&nbsp;</td>
			<td>
				&nbsp;</td>
		</tr>
	</tbody>
</table>

Click on RTL icon. Note that only the first cell of the two selected is in RTL.

[Garry Yao]

@Saar, the above cited TC is a bug of the domiterator reported with [6324], new patch covers it.

[Sa'ar Zac Elias]

• Start with the following content and selection:

  <table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
  	<tbody>
  		<tr>
  			[<td dir="rtl">
  				a</td>
  			<td dir="rtl">
  				b</td>
  		</tr>
  		<tr>
  			<td>
  				&nbsp;</td>
  			<td>
  				&nbsp;</td>]
  		</tr>
  	</tbody>
  </table>
  

• Click on LTR button.

Note that the table is corrupted.

[Garry Yao]

Nice catch, but yet another bug from domiterator.

[Garry Yao]

Fixed with [6333].