FCKeditor.Net: UserFilesPath

[anonymous]

in "FileWorkerBase.cs" -> "UserFilesPath" property there is a mistake in order to determine which of "sUserFilesPath" variable will be set. Watch this:

[original code]

...
...
// Otherwise use the default value.
if ( sUserFilesPath == null || sUserFilesPath.Length
== 0 )
sUserFilesPath = DEFAULT_USER_FILES_PATH ;

// Try to get from the URL.
if ( sUserFilesPath == null || sUserFilesPath.Length
== 0 )
{
sUserFilesPath = Request.QueryString
["ServerPath"] ;
}
...

code

spotted? "Try to get from the URL." never works.

[new code]

...
...
// Otherwise use the default value.
// Try to get from the URL.
if ( sUserFilesPath == null || sUserFilesPath.Length
== 0 )
{
sUserFilesPath = Request.QueryString
["ServerPath"] ;
}
if ( sUserFilesPath == null || sUserFilesPath.Length
== 0 )
sUserFilesPath = DEFAULT_USER_FILES_PATH ;
...

code

Greetings, Gürhan Başbuğ.

---

Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1368066&group_id=75348&atid=543653

[martinkou]

Because of security issues, the possibility of passing the UserFilesPath through the URL has been disabled. It is a quite easily hackable feature. We must still decide if it is a good thing to leave this hole opened on FCKeditor.

---

Moved from SF. Original poster: fredck