Getting Unresponsive Script Error when we try to paste Numbered/Bulleted lists with one more than one level

[Satya Minnekanti]

To reproduce the defect:

1. Open Ajax sample, Copy Numbered/Bulleted list from the attached doc and open Paste from Word dialog.

2. Paste the content in to the dialog and press OK button.

Expected Result:

Numbered/Bulleted list is pasted properly.

Actual Result:

we are getting an Unresponsive Script Error

[Wiktor Walc]

Caused by [6629]

[Jakub Ś]

It causes all bowsers to hang, except Opera - everything looks fine there.

[Wiktor Walc]

Note: I managed to trigger this bug in IE8 when working with lists, without pasting the attached (or any other) document from Word. I cannot find a way now to trigger this bug again, but it definitely happened.

[Frederico Caldeira Knabben]

I've found a reduced tc for this issue. Just load the following:

<ol>
	<li>1</li>
	<ol>
		<li>2</li>
	</ol>
	<li>3</li>
</ol>

It hangs the editor.

[Frederico Caldeira Knabben]

The above case is not covered here ([6643]):
​http://ckeditor.t/dt/core/htmlparser/htmlparser.html

[Frederico Caldeira Knabben]

• not => now

[Sa'ar Zac Elias]

Patch removes the changes that are not required to fix either bugs.

[Frederico Caldeira Knabben]

Some of tests are not passing after patch:
​http://ckeditor.t/dt/core/htmlparser/fragment.html

In fact I found it strange that that code has been introduced but it's not needed.

[Garry Yao]

Patch targets also #7497

[Frederico Caldeira Knabben]

Please, let's start to avoid enlarging parameters lists on functions calls just to hack the code. A simple list check on a new entry on CKEDITOR.dtd will probably make it work in the same way, having much cleaner code.

Additionally, please review the changes when creating patches. There is some minor unnecessary code formatting changes there.

[Garry Yao]

Please, let's start to avoid enlarging parameters lists on functions calls just to hack the code

I'm not sure as:

1. We're talking about an internally used function;
2. The optional close is not a dtd semantics but used when we're opening a new (fixing) tag dynamically.

[Frederico Caldeira Knabben]

Replying to garry.yao:

1. We're talking about an internally used function;

Sorry, this is not a good excuse to mess up the code.

1. The optional close is not a dtd semantics but used when we're opening a new (fixing) tag dynamically.

I got your point now.

---

Go ahead committing the change on fragment.js, but do not change element.js. Other than having duplicated code there on the last patch, there is no need at all to initialize those properties there, especially considering that this is an internal flag exclusive to the fragment.js code.

[Sa'ar Zac Elias]

Fixed with [6646].