Ticket #805 (closed Bug: fixed)

Opened 11 months ago

Last modified 3 months ago

Keystroke bypass disabled buttons in source mode

Reported by: neym@users.sourceforge.net Assigned to: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Source View Version:
Keywords: SF Confirmed Review+ Cc:

Description

When in source mode, certain functions are grayed out (find, font color, etc). When these functions are assigned to a keystroke they are still accessible via that keystroke.

To reproduce: - Assign a keystroke to Find in FCKConfig. - Press that keystroke while in source mode.

Result: Firebug reports error "oEditor.FCK.EditorDocument has no properties"

---

Noticed also that there are a lot of functions (add bullets, etc) that aren't grayed out in the button bar that also cause the same Firebug error report.

--Michael

Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1675277&group_id=75348&atid=543653

Attachments

805.patch (0.7 kB) - added by alfonsoml on 01/30/08 23:21:15.
Proposed SVN patch

Change History

06/25/07 10:17:57 changed by martinkou

  • reporter changed from martinkou to neym@users.sourceforge.net.

10/07/07 00:54:34 changed by alfonsoml

  • owner changed.
  • component changed from General to UI : Source View.

01/30/08 14:05:15 changed by w.olchawa

  • keywords changed from SF to SF Confirmed.

Confirmed

IE and IE7: the assigned keystrokes open the function window e.g. find/replace in the source view and the following error shows:

'oEditor.FCK.EditorDocument.body' is null or not and object.

Not all of the functions behave in this way. Some of them e.g.TextColor are activated when using the keystroke and they appear in random place

FF2 : the assigned keystrokes only open the windows. They don't open menus like e.g.TextColor

There isn't one rule for this bug so it should be further investigated.

01/30/08 23:21:15 changed by alfonsoml

  • attachment 805.patch added.

Proposed SVN patch

01/30/08 23:23:08 changed by alfonsoml

  • keywords changed from SF Confirmed to SF Confirmed Review?.
  • owner set to alfonsoml.
  • status changed from new to assigned.

Thanks to the work done by Martinkou now the commands always return the proper state, so this is very easy to fix.

02/05/08 00:49:32 changed by fredck

  • keywords changed from SF Confirmed Review? to SF Confirmed Review+.

Please include the changelog entry.

02/05/08 00:51:07 changed by fredck

  • milestone set to FCKeditor 2.6.

02/05/08 21:52:21 changed by alfonsoml

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed with [1479]