Ticket #822 (closed New Feature: fixed)

Opened 17 months ago

Last modified 3 months ago

Add <th> tag support

Reported by: acmoll@… Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version:
Keywords: SF Confirmed Review+ Cc: alfonsoml, liane@…, bngobngo@…, carstanje@…, balliano@…

Description (last modified by martinkou) (diff)

Be able to add and edit <th> (table header) tags.


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1215407&group_id=75348&atid=543656

Attachments

822.patch (37.9 KB) - added by martinkou 9 months ago.
822_1.patch (39.1 KB) - added by alfonsoml 3 months ago.
Revised patch
822_2.patch (40.2 KB) - added by alfonsoml 3 months ago.
Revised patch

Change History

Changed 17 months ago by martinkou

  • cc alfonsoml, liane@…, bngobngo@…, carstanje@…, balliano@… added
  • description modified (diff)
  • reporter changed from martinkou to acmoll@…

https://sourceforge.net/support/tracker.php?aid=1435863 https://sourceforge.net/support/tracker.php?aid=1166727 https://sourceforge.net/support/tracker.php?aid=1079985 https://sourceforge.net/support/tracker.php?aid=1078586 have been marked as duplicate of this one.


Moved from SF. Original poster: alfonsoml

I add my vote to this feature request, I miss it big time!!!


Moved from SF. Original poster: liane

Me to want this. Please include it in the Table Property dialog box.


Moved from SF. Original poster: bngobngo

This would be great! This way you can control a table better with CSS. The user will see the right format directly when creating a new table.


Moved from SF. Original poster: carstanje

I think this would be a great addition to the editor..

also if this is going to be implemented im guessing the scope attribute would be added as well..

Also may i suggest that <thead>, <tbody> and <tfoot> alos be implemented..

Excellent Work

Leevi Graham


Moved from SF. Original poster: Anonymous

Hi folks, I also think this feature is very important to generate accessible HTML, w3c requires a correct usage of the td/th so I think fck need it.

fabrizio


Moved from SF. Original poster: balliano

Changed 16 months ago by fredck

#1024 has been marked as a DUP.

Changed 16 months ago by fredck

  • milestone set to FCKeditor 2.6

Changed 9 months ago by w.olchawa

  • keywords Confirmed added

Changed 9 months ago by martinkou

  • owner set to martinkou
  • status changed from new to assigned

Changed 9 months ago by martinkou

Changed 9 months ago by martinkou

  • keywords Review? added

Changed 9 months ago by alfonsoml

  • keywords Review- added; Review? removed

An old patch is available here, (just to check that the new one does cover all the things outlined there): http://sourceforge.net/tracker/index.php?func=detail&aid=1283047&group_id=75348&atid=543655

You should wrap that code in a renameNode function like it was suggested here: http://sourceforge.net/tracker/index.php?func=detail&aid=1409217&group_id=75348&atid=543655 so it can be reused for changing all the cells in a row or column like proposed here: http://sourceforge.net/tracker/index.php?func=detail&aid=1409409&group_id=75348&atid=543655

Changed 9 months ago by fredck

  • milestone changed from FCKeditor 2.6 to FCKeditor 2.7

All table related tickets have been retargeted to the 2.7. This one was missing.

Changed 5 months ago by martinkou

  • owner martinkou deleted
  • status changed from assigned to new

Changed 5 months ago by martinkou

  • milestone set to CKEditor 3.0

Changed 3 months ago by alfonsoml

Revised patch

Changed 3 months ago by alfonsoml

  • keywords Review? added; Review- removed
  • owner set to alfonsoml
  • status changed from new to assigned
  • milestone CKEditor 3.0 deleted

I've adjusted the previous patch, fixing a bug that compared a function to a string and adding a little fix in the cell selection logic to take TH into account.

Changed 3 months ago by alfonsoml

again, I forgot the what's new:

		<li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/822">#822</a>] The table cell
			dialog allows to switch between normal data cells or header cells (TD vs TH). </li>

Changed 3 months ago by alfonsoml

Revised patch

Changed 3 months ago by alfonsoml

I've added a new patch to include the what's new and the empty style problem mentioned by Shri46 in http://www.fckeditor.net/forums/viewtopic.php?f=11&t=10726&p=28794#p28791

Changed 3 months ago by martinkou

  • keywords Review+ added; Review? removed

Changed 3 months ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to FCKeditor 2.6.4

Fixed with [2363]

Note: See TracTickets for help on using tickets.