Ticket #1643 (closed Bug: fixed)

Opened 5 months ago

Last modified 5 months ago

several strict warnings

Reported by: alfonsoml Assigned to: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version:
Keywords: Review+ Cc:

Description

Running with strict warnings On in Firefox shows several little problems in the console. Due to other pending changes I can't generate a clean diff to fix all of them, so this fixes just some and the others will be fixed later

Attachments

1643.patch (2.0 kB) - added by alfonsoml on 12/08/07 12:48:26.
fix for several of the warnings
1643_2.patch (4.2 kB) - added by fredck on 12/14/07 17:21:36.
1643_3.patch (4.7 kB) - added by fredck on 12/14/07 17:52:43.

Change History

12/08/07 12:48:26 changed by alfonsoml

  • attachment 1643.patch added.

fix for several of the warnings

12/08/07 12:49:23 changed by alfonsoml

  • keywords set to Review?.

The changes shouldn't affect the behavior at all

12/14/07 17:21:36 changed by fredck

  • attachment 1643_2.patch added.

12/14/07 17:30:42 changed by fredck

Review+ for your changes Alfonso, but I was still having some warnings. I've attached a new patch, which includes also the changlog entry.

There is still one warning that I don't feel sure on how to solve it:

function eval must be called directly, and not by way of a function 
of another name
... editor/_source/fckeditorapi.js
Line 124

But I think we can live with it.

12/14/07 17:52:43 changed by fredck

  • attachment 1643_3.patch added.

12/14/07 17:53:18 changed by fredck

The latest proposal includes the removal of a duplicate HasFocus in fck.js.

12/14/07 18:02:18 changed by alfonsoml

  • keywords changed from Review? to Review+.

the third patch fixes all the main issues (maybe there are other problems after using some commands or dialogs, but they can be fixed later).

For the eval, Firefox 3 doesn't use it, instead it injects a <script> in the parent element like it's done in Safari.

12/14/07 18:14:56 changed by fredck

Fixed with [1211]. Click here for more info about our SVN system.

12/14/07 18:15:03 changed by fredck

  • status changed from new to closed.
  • resolution set to fixed.

12/14/07 18:15:10 changed by fredck

  • milestone set to FCKeditor 2.6.