several strict warnings

[alfonsoml]

Running with strict warnings On in Firefox shows several little problems in the console. Due to other pending changes I can't generate a clean diff to fix all of them, so this fixes just some and the others will be fixed later

[alfonsoml]

fix for several of the warnings

[alfonsoml]

The changes shouldn't affect the behavior at all

[fredck]

Review+ for your changes Alfonso, but I was still having some warnings. I've attached a new patch, which includes also the changlog entry.

There is still one warning that I don't feel sure on how to solve it:

function eval must be called directly, and not by way of a function 
of another name
... editor/_source/fckeditorapi.js
Line 124

But I think we can live with it.

[fredck]

The latest proposal includes the removal of a duplicate HasFocus in fck.js.

[alfonsoml]

the third patch fixes all the main issues (maybe there are other problems after using some commands or dialogs, but they can be fixed later).

For the eval, Firefox 3 doesn't use it, instead it injects a <script> in the parent element like it's done in Safari.

[fredck]

Fixed with [1211]. Click here for more info about our SVN system.