Ticket #1642 (closed Bug: fixed)

Opened 2 years ago

Last modified 2 years ago

window.onresize causes flicker running in chrome

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version:
Keywords: Review+ Cc:

Description

While setting the  Write Area extension one of the problems was that the editor did flicker continously, it was very annoying and finally I found that it was due to the window.onresize of the fckeditor.html and fckdialog.html

The problem is that in this situation it gets the event also from the inner frames, so it never ends the resizing.

Attachments

1642.patch Download (2.6 KB) - added by alfonsoml 2 years ago.
Proposed SVN patch

Change History

Changed 2 years ago by alfonsoml

Proposed SVN patch

Changed 2 years ago by alfonsoml

  • keywords Review? added
  • status changed from new to assigned

The proposed patch includes the required changes: get the event and check the document with

		// Running in Chrome makes the window receive the event including subframes.
		// we care only about this window. Ticket #1642
		if ( e && e.originalTarget !== document )
				return ;

but it also includes some little clean up, in my test everything seems to keep working fine.

Changed 2 years ago by martinkou

  • keywords Review+ added; Review? removed

The only real change in the patch is the event.originalTarget check for Gecko, the other changes are cosmetic changes. So it shouldn't break anything, and it didn't in my tests. So I'm giving it a Review+.

Changed 2 years ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to FCKeditor 2.6

Fixed with [1188]

Note: See TracTickets for help on using tickets.