Ticket #4341 (closed New Feature: fixed)

Opened 7 months ago

Last modified 4 months ago

Implement ShowBorders

Reported by: alfonsoml Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: 3.0
Keywords: Confirmed Review+ Cc:

Description

Implement the ShowBorders feature.

Instead of being only a configuration option, I think that it would be much better if it was possible to use it as a command, so the people could opt to put it in the toolbar

Attachments

4341.patch Download (4.4 KB) - added by garry.yao 5 months ago.
4341_2.patch Download (6.1 KB) - added by garry.yao 5 months ago.
4341_3.patch Download (6.1 KB) - added by garry.yao 4 months ago.

Change History

Changed 5 months ago by garry.yao

  • keywords Confirmed added
  • owner set to garry.yao
  • status changed from new to assigned

Changed 5 months ago by garry.yao

Changed 5 months ago by garry.yao

  • keywords Review? added

Implement it as a command, and I'm currently disabled it in IE, with the concern of the implementation based on HTC would not accepted here. We may even considering a datafilter rule for IE.

Changed 5 months ago by fredck

  • keywords Review- added; Review? removed

It must also work with IE.

Also, the borderStyleRegex replacement is not necessary as we have it just once in the template.

Changed 5 months ago by garry.yao

  • keywords Review? added; Review- removed

Manual TCs added at :  http://ckeditor.t/tt/4341/1.html

Changed 5 months ago by garry.yao

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed
  • There should be no changes to the config.js file as those are plugin specific settings.
  • In any case, the effective code definition of startupShowBorders is not needed. It should be a "documentation only" definition, just like the dialog plugin settings.
  • What about IE6? If I can make it there (V2) I can make it everywhere, right?

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

As discussed with Fred today, as we have almost complete control over the editor input, we could innovate a bit by simply using a css marker class for showborders style instead of the solution based on selectors and HTC before.
New Ticket Test added at :
 http://ckeditor.t/tt/4341/2.html.  http://ckeditor.t/tt/4341/3.html.

Changed 4 months ago by fredck

#4735 has been marked as DUP.

Changed 4 months ago by fredck

  • keywords Review+ added; Review? removed

There is a typo in line 21 (an extra comma), which breaks the feature in IE6. Please fix it before committing.

Changed 4 months ago by garry.yao

  • status changed from assigned to closed
  • resolution set to fixed

Nice catch[[BR]] Fixed with [4568] and [4569].

Note: See TracTickets for help on using tickets.